Browse Source

xenbus_xs.c: fix a use-after-free

This patch fixes an obvious use-after-free spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Adrian Bunk 18 years ago
parent
commit
98ac0e53fa
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/xen/xenbus/xenbus_xs.c

+ 1 - 1
drivers/xen/xenbus/xenbus_xs.c

@@ -782,8 +782,8 @@ static int process_msg(void)
 		msg->u.watch.vec = split(body, msg->hdr.len,
 		msg->u.watch.vec = split(body, msg->hdr.len,
 					 &msg->u.watch.vec_size);
 					 &msg->u.watch.vec_size);
 		if (IS_ERR(msg->u.watch.vec)) {
 		if (IS_ERR(msg->u.watch.vec)) {
-			kfree(msg);
 			err = PTR_ERR(msg->u.watch.vec);
 			err = PTR_ERR(msg->u.watch.vec);
+			kfree(msg);
 			goto out;
 			goto out;
 		}
 		}