s390/vmlogrdr: fix array access in vmlogrdr_open() · 9784bd4f1a - Gogs

s390/vmlogrdr: fix array access in vmlogrdr_open()

Fix check within vmlogrdr_open() if the minor address is not larger
than the number of array elements.

Found with "smatch":

drivers/s390/char/vmlogrdr.c:318 vmlogrdr_open() warn:
  buffer overflow 'sys_ser' 3 <= 3

Acked-by: Stefan Weinhuber <wein@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

Heiko Carstens 11 years ago

parent

0ebfd313fd

commit

9784bd4f1a

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
drivers/s390/char/vmlogrdr.c
							 
								View File
							
				@@ -313,7 +313,7 @@ static int vmlogrdr_open (struct inode *inode, struct file *filp)
			
				 	int ret;
			
				 	dev_num = iminor(inode);
			
				-	if (dev_num > MAXMINOR)
			
				+	if (dev_num >= MAXMINOR)
			
				 		return -ENODEV;
			
				 	logptr = &sys_ser[dev_num];