Jelajahi Sumber

autofs4: collect version check return

The function check_dev_ioctl_version() returns an error code upon fail but
it isn't captured and returned in validate_dev_ioctl() as it should be.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Ian Kent <raven@themaw.net>
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Ian Kent 16 tahun lalu
induk
melakukan
96b0317906
1 mengubah file dengan 3 tambahan dan 2 penghapusan
  1. 3 2
      fs/autofs4/dev-ioctl.c

+ 3 - 2
fs/autofs4/dev-ioctl.c

@@ -128,9 +128,10 @@ static inline void free_dev_ioctl(struct autofs_dev_ioctl *param)
  */
  */
 static int validate_dev_ioctl(int cmd, struct autofs_dev_ioctl *param)
 static int validate_dev_ioctl(int cmd, struct autofs_dev_ioctl *param)
 {
 {
-	int err = -EINVAL;
+	int err;
 
 
-	if (check_dev_ioctl_version(cmd, param)) {
+	err = check_dev_ioctl_version(cmd, param);
+	if (err) {
 		AUTOFS_WARN("invalid device control module version "
 		AUTOFS_WARN("invalid device control module version "
 		     "supplied for cmd(0x%08x)", cmd);
 		     "supplied for cmd(0x%08x)", cmd);
 		goto out;
 		goto out;