Эх сурвалжийг харах

IB/qib: Completion queue callback needs to be single threaded

Workqueues aren't exactly equivalent to tasklets since the callback
function may be called from multiple CPUs before the callback returns.
This causes completion notification callbacks to have MT bugs since
they weren't expecting this behavior. The fix is to use a single
threaded work queue.

Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Ralph Campbell 15 жил өмнө
parent
commit
950aff5394

+ 1 - 1
drivers/infiniband/hw/qib/qib_init.c

@@ -1059,7 +1059,7 @@ static int __init qlogic_ib_init(void)
 		goto bail_dev;
 		goto bail_dev;
 	}
 	}
 
 
-	qib_cq_wq = create_workqueue("qib_cq");
+	qib_cq_wq = create_singlethread_workqueue("qib_cq");
 	if (!qib_cq_wq) {
 	if (!qib_cq_wq) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto bail_wq;
 		goto bail_wq;