Browse Source

spidernet: skb used after netif_receive_skb

The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Florin Malita 18 years ago
parent
commit
93c1d3b790
1 changed files with 3 additions and 3 deletions
  1. 3 3
      drivers/net/spider_net.c

+ 3 - 3
drivers/net/spider_net.c

@@ -1014,12 +1014,12 @@ spider_net_pass_skb_up(struct spider_net_descr *descr,
 		 */
 		 */
 	}
 	}
 
 
-	/* pass skb up to stack */
-	netif_receive_skb(skb);
-
 	/* update netdevice statistics */
 	/* update netdevice statistics */
 	card->netdev_stats.rx_packets++;
 	card->netdev_stats.rx_packets++;
 	card->netdev_stats.rx_bytes += skb->len;
 	card->netdev_stats.rx_bytes += skb->len;
+
+	/* pass skb up to stack */
+	netif_receive_skb(skb);
 }
 }
 
 
 #ifdef DEBUG
 #ifdef DEBUG