Browse Source

ktest: Use oldnoconfig instead of yes command

Running the command "yes ''" through the make oldconfig may enable
things we do not want enabled. If something is default enabled, the
yes command with '' as an argument will enable it.

Use oldnoconfig, which runs everything as if 'no' was used.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Steven Rostedt 14 years ago
parent
commit
9386c6ab7a
1 changed files with 2 additions and 3 deletions
  1. 2 3
      tools/testing/ktest/ktest.pl

+ 2 - 3
tools/testing/ktest/ktest.pl

@@ -694,7 +694,6 @@ sub check_buildlog {
 sub build {
 sub build {
     my ($type) = @_;
     my ($type) = @_;
     my $defconfig = "";
     my $defconfig = "";
-    my $append = "";
 
 
     unlink $buildlog;
     unlink $buildlog;
 
 
@@ -707,7 +706,7 @@ sub build {
 
 
     # old config can ask questions
     # old config can ask questions
     if ($type eq "oldconfig") {
     if ($type eq "oldconfig") {
-	$append = "yes ''|";
+	$type = "oldnoconfig";
 
 
 	# allow for empty configs
 	# allow for empty configs
 	run_command "touch $outputdir/.config";
 	run_command "touch $outputdir/.config";
@@ -737,7 +736,7 @@ sub build {
 	$defconfig = "KCONFIG_ALLCONFIG=$minconfig";
 	$defconfig = "KCONFIG_ALLCONFIG=$minconfig";
     }
     }
 
 
-    run_command "$append $defconfig $make $type" or
+    run_command "$defconfig $make $type" or
 	dodie "failed make config";
 	dodie "failed make config";
 
 
     $redirect = "$buildlog";
     $redirect = "$buildlog";