Browse Source

pinctrl/lantiq: the pinconf OD parameter argument was ignored

When setting the OpenDrain bit we should really honour the
argument passed inside the devicetree.

Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
John Crispin 12 years ago
parent
commit
9338628737
1 changed files with 4 additions and 1 deletions
  1. 4 1
      drivers/pinctrl/pinctrl-xway.c

+ 4 - 1
drivers/pinctrl/pinctrl-xway.c

@@ -494,7 +494,10 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
 			reg = GPIO3_OD;
 		else
 			reg = GPIO_OD(pin);
-		gpio_setbit(info->membase[0], reg, PORT_PIN(pin));
+		if (arg == 0)
+			gpio_setbit(info->membase[0], reg, PORT_PIN(pin));
+		else
+			gpio_clearbit(info->membase[0], reg, PORT_PIN(pin));
 		break;
 
 	case LTQ_PINCONF_PARAM_PULL: