Эх сурвалжийг харах

ehea: Dont check NETIF_F_TSO in TX path

It seems like the ehea xmit routine and an ethtool change of TSO
mode could race, resulting in corrupt packets. Checking gso_size
is enough and we can use the helper function.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Anton Blanchard 13 жил өмнө
parent
commit
921ddc19b9

+ 1 - 1
drivers/net/ethernet/ibm/ehea/ehea_main.c

@@ -1787,7 +1787,7 @@ static inline void write_swqe2_data(struct sk_buff *skb, struct net_device *dev,
 	swqe->descriptors = 0;
 	swqe->descriptors = 0;
 	sg1entry_contains_frag_data = 0;
 	sg1entry_contains_frag_data = 0;
 
 
-	if ((dev->features & NETIF_F_TSO) && skb_shinfo(skb)->gso_size)
+	if (skb_is_gso(skb))
 		write_swqe2_TSO(skb, swqe, lkey);
 		write_swqe2_TSO(skb, swqe, lkey);
 	else
 	else
 		write_swqe2_nonTSO(skb, swqe, lkey);
 		write_swqe2_nonTSO(skb, swqe, lkey);