瀏覽代碼

kcore: more fixes for init

proc_kcore_init() doesn't check NULL case.  fix it and remove unnecessary
comments.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
KAMEZAWA Hiroyuki 15 年之前
父節點
當前提交
90396f96b7
共有 1 個文件被更改,包括 4 次插入1 次删除
  1. 4 1
      fs/proc/kcore.c

+ 4 - 1
fs/proc/kcore.c

@@ -606,6 +606,10 @@ static int __init proc_kcore_init(void)
 {
 {
 	proc_root_kcore = proc_create("kcore", S_IRUSR, NULL,
 	proc_root_kcore = proc_create("kcore", S_IRUSR, NULL,
 				      &proc_kcore_operations);
 				      &proc_kcore_operations);
+	if (!proc_root_kcore) {
+		printk(KERN_ERR "couldn't create /proc/kcore\n");
+		return 0; /* Always returns 0. */
+	}
 	/* Store text area if it's special */
 	/* Store text area if it's special */
 	proc_kcore_text_init();
 	proc_kcore_text_init();
 	/* Store vmalloc area */
 	/* Store vmalloc area */
@@ -615,7 +619,6 @@ static int __init proc_kcore_init(void)
 	/* Store direct-map area from physical memory map */
 	/* Store direct-map area from physical memory map */
 	kcore_update_ram();
 	kcore_update_ram();
 	hotplug_memory_notifier(kcore_callback, 0);
 	hotplug_memory_notifier(kcore_callback, 0);
-	/* Other special area, area-for-module etc is arch specific. */
 
 
 	return 0;
 	return 0;
 }
 }