فهرست منبع

genirq: Add missing break in __irq_set_trigger()

The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.

Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Thomas Gleixner 14 سال پیش
والد
کامیت
8fff39e069
1فایلهای تغییر یافته به همراه1 افزوده شده و 0 حذف شده
  1. 1 0
      kernel/irq/manage.c

+ 1 - 0
kernel/irq/manage.c

@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
 		if (chip != desc->irq_data.chip)
 		if (chip != desc->irq_data.chip)
 			irq_chip_set_defaults(desc->irq_data.chip);
 			irq_chip_set_defaults(desc->irq_data.chip);
 		ret = 0;
 		ret = 0;
+		break;
 	default:
 	default:
 		pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
 		pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
 		       flags, irq, chip->irq_set_type);
 		       flags, irq, chip->irq_set_type);