9p: potential ERR_PTR() dereference · 8f587df479 - Gogs

9p: potential ERR_PTR() dereference

p9_client_walk() can return error values if we run out of space or there
is a problem with the network.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>

Dan Carpenter 15 years ago

parent

2bfc96a127

commit

8f587df479

1 changed files with 2 additions and 1 deletions

Split View Show Diff Stats

						
							+ 2
							
							- 1
						
fs/9p/fid.c
							 
								View File
							
				@@ -242,7 +242,8 @@ struct p9_fid *v9fs_fid_lookup(struct dentry *dentry)
			
				 	}
			
				 	kfree(wnames);
			
				 fid_out:
			
				-	v9fs_fid_add(dentry, fid);
			
				+	if (!IS_ERR(fid))
			
				+		v9fs_fid_add(dentry, fid);
			
				 err_out:
			
				 	up_read(&v9ses->rename_sem);
			
				 	return fid;