瀏覽代碼

BUG_ON cleanups in arch/i386

This changes a couple of if() BUG(); constructs to
BUG_ON(); so it can be safely optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Eric Sesterhenn 19 年之前
父節點
當前提交
8d8f3cbe77
共有 4 個文件被更改,包括 4 次插入8 次删除
  1. 1 2
      arch/i386/kernel/cpu/common.c
  2. 1 2
      arch/i386/kernel/efi.c
  3. 1 2
      arch/i386/mm/discontig.c
  4. 1 2
      arch/i386/mm/init.c

+ 1 - 2
arch/i386/kernel/cpu/common.c

@@ -669,8 +669,7 @@ old_gdt:
 	 */
 	atomic_inc(&init_mm.mm_count);
 	current->active_mm = &init_mm;
-	if (current->mm)
-		BUG();
+	BUG_ON(current->mm);
 	enter_lazy_tlb(&init_mm, current);
 
 	load_esp0(t, thread);

+ 1 - 2
arch/i386/kernel/efi.c

@@ -498,8 +498,7 @@ void __init efi_enter_virtual_mode(void)
 		check_range_for_systab(md);
 	}
 
-	if (!efi.systab)
-		BUG();
+	BUG_ON(!efi.systab);
 
 	status = phys_efi_set_virtual_address_map(
 			memmap.desc_size * memmap.nr_map,

+ 1 - 2
arch/i386/mm/discontig.c

@@ -153,8 +153,7 @@ static void __init find_max_pfn_node(int nid)
 	 */
 	if (node_start_pfn[nid] > max_pfn)
 		node_start_pfn[nid] = max_pfn;
-	if (node_start_pfn[nid] > node_end_pfn[nid])
-		BUG();
+	BUG_ON(node_start_pfn[nid] > node_end_pfn[nid]);
 }
 
 /* 

+ 1 - 2
arch/i386/mm/init.c

@@ -569,8 +569,7 @@ void __init mem_init(void)
 	int bad_ppro;
 
 #ifdef CONFIG_FLATMEM
-	if (!mem_map)
-		BUG();
+	BUG_ON(!mem_map);
 #endif
 	
 	bad_ppro = ppro_with_ram_bug();