فهرست منبع

Bluetooth: l2cap and rfcomm: fix 1 byte infoleak to userspace.

Structures "l2cap_conninfo" and "rfcomm_conninfo" have one padding
byte each. This byte in "cinfo" is copied to userspace uninitialized.

Signed-off-by: Filip Palian <filip.palian@pjwstk.edu.pl>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Filip Palian 14 سال پیش
والد
کامیت
8d03e971cf
2فایلهای تغییر یافته به همراه2 افزوده شده و 0 حذف شده
  1. 1 0
      net/bluetooth/l2cap_sock.c
  2. 1 0
      net/bluetooth/rfcomm/sock.c

+ 1 - 0
net/bluetooth/l2cap_sock.c

@@ -413,6 +413,7 @@ static int l2cap_sock_getsockopt_old(struct socket *sock, int optname, char __us
 			break;
 			break;
 		}
 		}
 
 
+		memset(&cinfo, 0, sizeof(cinfo));
 		cinfo.hci_handle = chan->conn->hcon->handle;
 		cinfo.hci_handle = chan->conn->hcon->handle;
 		memcpy(cinfo.dev_class, chan->conn->hcon->dev_class, 3);
 		memcpy(cinfo.dev_class, chan->conn->hcon->dev_class, 3);
 
 

+ 1 - 0
net/bluetooth/rfcomm/sock.c

@@ -788,6 +788,7 @@ static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __u
 
 
 		l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
 		l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
 
 
+		memset(&cinfo, 0, sizeof(cinfo));
 		cinfo.hci_handle = conn->hcon->handle;
 		cinfo.hci_handle = conn->hcon->handle;
 		memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);
 		memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);