Przeglądaj źródła

[PATCH] Uninitialized variable in drivers/net/wan/syncppp.c

For len equal to 4, we never call sppp_lcp_conf_parse_options(),
therefore rmagic does not get initialized.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Eric Sesterhenn 18 lat temu
rodzic
commit
8c6ba51bda
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      drivers/net/wan/syncppp.c

+ 1 - 1
drivers/net/wan/syncppp.c

@@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp *sp, struct sk_buff *skb)
 	struct net_device *dev = sp->pp_if;
 	struct net_device *dev = sp->pp_if;
 	int len = skb->len;
 	int len = skb->len;
 	u8 *p, opt[6];
 	u8 *p, opt[6];
-	u32 rmagic;
+	u32 rmagic = 0;
 
 
 	if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
 	if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
 		if (sp->pp_flags & PP_DEBUG)
 		if (sp->pp_flags & PP_DEBUG)