Sfoglia il codice sorgente

pptp: fix skb leak in pptp_xmit()

In case we cant transmit skb, we must free it

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eric Dumazet 13 anni fa
parent
commit
8bae8bd6cb
1 ha cambiato i file con 2 aggiunte e 0 eliminazioni
  1. 2 0
      drivers/net/pptp.c

+ 2 - 0
drivers/net/pptp.c

@@ -285,8 +285,10 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
 	ip_send_check(iph);
 	ip_send_check(iph);
 
 
 	ip_local_out(skb);
 	ip_local_out(skb);
+	return 1;
 
 
 tx_error:
 tx_error:
+	kfree_skb(skb);
 	return 1;
 	return 1;
 }
 }