Эх сурвалжийг харах

V4L/DVB: s2255drv: remove dead code

My concern initially was we dereference "dev" in the parameter list to
s2255_dev_err() but it turns out that code path is never used.
The s2255_stop_readpipe() is only called from one place and "dev" is
never null.  So this patch just removes the whole condition here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: linux-dev@sensoray.com
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Dan Carpenter 15 жил өмнө
parent
commit
8b661b508b

+ 1 - 4
drivers/media/video/s2255drv.c

@@ -2528,10 +2528,7 @@ static int s2255_stop_acquire(struct s2255_dev *dev, unsigned long chn)
 static void s2255_stop_readpipe(struct s2255_dev *dev)
 static void s2255_stop_readpipe(struct s2255_dev *dev)
 {
 {
 	struct s2255_pipeinfo *pipe = &dev->pipe;
 	struct s2255_pipeinfo *pipe = &dev->pipe;
-	if (dev == NULL) {
-		s2255_dev_err(&dev->udev->dev, "invalid device\n");
-		return;
-	}
+
 	pipe->state = 0;
 	pipe->state = 0;
 	if (pipe->stream_urb) {
 	if (pipe->stream_urb) {
 		/* cancel urb */
 		/* cancel urb */