|
@@ -30,7 +30,7 @@
|
|
static unsigned int blktrace_seq __read_mostly = 1;
|
|
static unsigned int blktrace_seq __read_mostly = 1;
|
|
|
|
|
|
static struct trace_array *blk_tr;
|
|
static struct trace_array *blk_tr;
|
|
-static int __read_mostly blk_tracer_enabled;
|
|
|
|
|
|
+static bool blk_tracer_enabled __read_mostly;
|
|
|
|
|
|
/* Select an alternative, minimalistic output than the original one */
|
|
/* Select an alternative, minimalistic output than the original one */
|
|
#define TRACE_BLK_OPT_CLASSIC 0x1
|
|
#define TRACE_BLK_OPT_CLASSIC 0x1
|
|
@@ -47,10 +47,9 @@ static struct tracer_flags blk_tracer_flags = {
|
|
};
|
|
};
|
|
|
|
|
|
/* Global reference count of probes */
|
|
/* Global reference count of probes */
|
|
-static DEFINE_MUTEX(blk_probe_mutex);
|
|
|
|
static atomic_t blk_probes_ref = ATOMIC_INIT(0);
|
|
static atomic_t blk_probes_ref = ATOMIC_INIT(0);
|
|
|
|
|
|
-static int blk_register_tracepoints(void);
|
|
|
|
|
|
+static void blk_register_tracepoints(void);
|
|
static void blk_unregister_tracepoints(void);
|
|
static void blk_unregister_tracepoints(void);
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -60,22 +59,39 @@ static void trace_note(struct blk_trace *bt, pid_t pid, int action,
|
|
const void *data, size_t len)
|
|
const void *data, size_t len)
|
|
{
|
|
{
|
|
struct blk_io_trace *t;
|
|
struct blk_io_trace *t;
|
|
|
|
+ struct ring_buffer_event *event = NULL;
|
|
|
|
+ int pc = 0;
|
|
|
|
+ int cpu = smp_processor_id();
|
|
|
|
+ bool blk_tracer = blk_tracer_enabled;
|
|
|
|
+
|
|
|
|
+ if (blk_tracer) {
|
|
|
|
+ pc = preempt_count();
|
|
|
|
+ event = trace_buffer_lock_reserve(blk_tr, TRACE_BLK,
|
|
|
|
+ sizeof(*t) + len,
|
|
|
|
+ 0, pc);
|
|
|
|
+ if (!event)
|
|
|
|
+ return;
|
|
|
|
+ t = ring_buffer_event_data(event);
|
|
|
|
+ goto record_it;
|
|
|
|
+ }
|
|
|
|
|
|
if (!bt->rchan)
|
|
if (!bt->rchan)
|
|
return;
|
|
return;
|
|
|
|
|
|
t = relay_reserve(bt->rchan, sizeof(*t) + len);
|
|
t = relay_reserve(bt->rchan, sizeof(*t) + len);
|
|
if (t) {
|
|
if (t) {
|
|
- const int cpu = smp_processor_id();
|
|
|
|
-
|
|
|
|
t->magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION;
|
|
t->magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION;
|
|
t->time = ktime_to_ns(ktime_get());
|
|
t->time = ktime_to_ns(ktime_get());
|
|
|
|
+record_it:
|
|
t->device = bt->dev;
|
|
t->device = bt->dev;
|
|
t->action = action;
|
|
t->action = action;
|
|
t->pid = pid;
|
|
t->pid = pid;
|
|
t->cpu = cpu;
|
|
t->cpu = cpu;
|
|
t->pdu_len = len;
|
|
t->pdu_len = len;
|
|
memcpy((void *) t + sizeof(*t), data, len);
|
|
memcpy((void *) t + sizeof(*t), data, len);
|
|
|
|
+
|
|
|
|
+ if (blk_tracer)
|
|
|
|
+ trace_buffer_unlock_commit(blk_tr, event, 0, pc);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
@@ -111,14 +127,8 @@ void __trace_note_message(struct blk_trace *bt, const char *fmt, ...)
|
|
unsigned long flags;
|
|
unsigned long flags;
|
|
char *buf;
|
|
char *buf;
|
|
|
|
|
|
- if (blk_tr) {
|
|
|
|
- va_start(args, fmt);
|
|
|
|
- ftrace_vprintk(fmt, args);
|
|
|
|
- va_end(args);
|
|
|
|
- return;
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
- if (!bt->msg_data)
|
|
|
|
|
|
+ if (unlikely(bt->trace_state != Blktrace_running &&
|
|
|
|
+ !blk_tracer_enabled))
|
|
return;
|
|
return;
|
|
|
|
|
|
local_irq_save(flags);
|
|
local_irq_save(flags);
|
|
@@ -148,8 +158,8 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
|
|
/*
|
|
/*
|
|
* Data direction bit lookup
|
|
* Data direction bit lookup
|
|
*/
|
|
*/
|
|
-static u32 ddir_act[2] __read_mostly = { BLK_TC_ACT(BLK_TC_READ),
|
|
|
|
- BLK_TC_ACT(BLK_TC_WRITE) };
|
|
|
|
|
|
+static const u32 ddir_act[2] = { BLK_TC_ACT(BLK_TC_READ),
|
|
|
|
+ BLK_TC_ACT(BLK_TC_WRITE) };
|
|
|
|
|
|
/* The ilog2() calls fall out because they're constant */
|
|
/* The ilog2() calls fall out because they're constant */
|
|
#define MASK_TC_BIT(rw, __name) ((rw & (1 << BIO_RW_ ## __name)) << \
|
|
#define MASK_TC_BIT(rw, __name) ((rw & (1 << BIO_RW_ ## __name)) << \
|
|
@@ -169,9 +179,9 @@ static void __blk_add_trace(struct blk_trace *bt, sector_t sector, int bytes,
|
|
unsigned long *sequence;
|
|
unsigned long *sequence;
|
|
pid_t pid;
|
|
pid_t pid;
|
|
int cpu, pc = 0;
|
|
int cpu, pc = 0;
|
|
|
|
+ bool blk_tracer = blk_tracer_enabled;
|
|
|
|
|
|
- if (unlikely(bt->trace_state != Blktrace_running ||
|
|
|
|
- !blk_tracer_enabled))
|
|
|
|
|
|
+ if (unlikely(bt->trace_state != Blktrace_running && !blk_tracer))
|
|
return;
|
|
return;
|
|
|
|
|
|
what |= ddir_act[rw & WRITE];
|
|
what |= ddir_act[rw & WRITE];
|
|
@@ -186,7 +196,7 @@ static void __blk_add_trace(struct blk_trace *bt, sector_t sector, int bytes,
|
|
return;
|
|
return;
|
|
cpu = raw_smp_processor_id();
|
|
cpu = raw_smp_processor_id();
|
|
|
|
|
|
- if (blk_tr) {
|
|
|
|
|
|
+ if (blk_tracer) {
|
|
tracing_record_cmdline(current);
|
|
tracing_record_cmdline(current);
|
|
|
|
|
|
pc = preempt_count();
|
|
pc = preempt_count();
|
|
@@ -236,7 +246,7 @@ record_it:
|
|
if (pdu_len)
|
|
if (pdu_len)
|
|
memcpy((void *) t + sizeof(*t), pdu_data, pdu_len);
|
|
memcpy((void *) t + sizeof(*t), pdu_data, pdu_len);
|
|
|
|
|
|
- if (blk_tr) {
|
|
|
|
|
|
+ if (blk_tracer) {
|
|
trace_buffer_unlock_commit(blk_tr, event, 0, pc);
|
|
trace_buffer_unlock_commit(blk_tr, event, 0, pc);
|
|
return;
|
|
return;
|
|
}
|
|
}
|
|
@@ -248,7 +258,7 @@ record_it:
|
|
static struct dentry *blk_tree_root;
|
|
static struct dentry *blk_tree_root;
|
|
static DEFINE_MUTEX(blk_tree_mutex);
|
|
static DEFINE_MUTEX(blk_tree_mutex);
|
|
|
|
|
|
-static void blk_trace_cleanup(struct blk_trace *bt)
|
|
|
|
|
|
+static void blk_trace_free(struct blk_trace *bt)
|
|
{
|
|
{
|
|
debugfs_remove(bt->msg_file);
|
|
debugfs_remove(bt->msg_file);
|
|
debugfs_remove(bt->dropped_file);
|
|
debugfs_remove(bt->dropped_file);
|
|
@@ -256,10 +266,13 @@ static void blk_trace_cleanup(struct blk_trace *bt)
|
|
free_percpu(bt->sequence);
|
|
free_percpu(bt->sequence);
|
|
free_percpu(bt->msg_data);
|
|
free_percpu(bt->msg_data);
|
|
kfree(bt);
|
|
kfree(bt);
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static void blk_trace_cleanup(struct blk_trace *bt)
|
|
|
|
+{
|
|
|
|
+ blk_trace_free(bt);
|
|
if (atomic_dec_and_test(&blk_probes_ref))
|
|
if (atomic_dec_and_test(&blk_probes_ref))
|
|
blk_unregister_tracepoints();
|
|
blk_unregister_tracepoints();
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
}
|
|
}
|
|
|
|
|
|
int blk_trace_remove(struct request_queue *q)
|
|
int blk_trace_remove(struct request_queue *q)
|
|
@@ -270,8 +283,7 @@ int blk_trace_remove(struct request_queue *q)
|
|
if (!bt)
|
|
if (!bt)
|
|
return -EINVAL;
|
|
return -EINVAL;
|
|
|
|
|
|
- if (bt->trace_state == Blktrace_setup ||
|
|
|
|
- bt->trace_state == Blktrace_stopped)
|
|
|
|
|
|
+ if (bt->trace_state != Blktrace_running)
|
|
blk_trace_cleanup(bt);
|
|
blk_trace_cleanup(bt);
|
|
|
|
|
|
return 0;
|
|
return 0;
|
|
@@ -414,11 +426,11 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
|
|
if (buts->name[i] == '/')
|
|
if (buts->name[i] == '/')
|
|
buts->name[i] = '_';
|
|
buts->name[i] = '_';
|
|
|
|
|
|
- ret = -ENOMEM;
|
|
|
|
bt = kzalloc(sizeof(*bt), GFP_KERNEL);
|
|
bt = kzalloc(sizeof(*bt), GFP_KERNEL);
|
|
if (!bt)
|
|
if (!bt)
|
|
- goto err;
|
|
|
|
|
|
+ return -ENOMEM;
|
|
|
|
|
|
|
|
+ ret = -ENOMEM;
|
|
bt->sequence = alloc_percpu(unsigned long);
|
|
bt->sequence = alloc_percpu(unsigned long);
|
|
if (!bt->sequence)
|
|
if (!bt->sequence)
|
|
goto err;
|
|
goto err;
|
|
@@ -429,11 +441,15 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
|
|
|
|
|
|
ret = -ENOENT;
|
|
ret = -ENOENT;
|
|
|
|
|
|
|
|
+ mutex_lock(&blk_tree_mutex);
|
|
if (!blk_tree_root) {
|
|
if (!blk_tree_root) {
|
|
blk_tree_root = debugfs_create_dir("block", NULL);
|
|
blk_tree_root = debugfs_create_dir("block", NULL);
|
|
- if (!blk_tree_root)
|
|
|
|
- return -ENOMEM;
|
|
|
|
|
|
+ if (!blk_tree_root) {
|
|
|
|
+ mutex_unlock(&blk_tree_mutex);
|
|
|
|
+ goto err;
|
|
|
|
+ }
|
|
}
|
|
}
|
|
|
|
+ mutex_unlock(&blk_tree_mutex);
|
|
|
|
|
|
dir = debugfs_create_dir(buts->name, blk_tree_root);
|
|
dir = debugfs_create_dir(buts->name, blk_tree_root);
|
|
|
|
|
|
@@ -471,14 +487,6 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
|
|
bt->pid = buts->pid;
|
|
bt->pid = buts->pid;
|
|
bt->trace_state = Blktrace_setup;
|
|
bt->trace_state = Blktrace_setup;
|
|
|
|
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
- if (atomic_add_return(1, &blk_probes_ref) == 1) {
|
|
|
|
- ret = blk_register_tracepoints();
|
|
|
|
- if (ret)
|
|
|
|
- goto probe_err;
|
|
|
|
- }
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
-
|
|
|
|
ret = -EBUSY;
|
|
ret = -EBUSY;
|
|
old_bt = xchg(&q->blk_trace, bt);
|
|
old_bt = xchg(&q->blk_trace, bt);
|
|
if (old_bt) {
|
|
if (old_bt) {
|
|
@@ -486,22 +494,12 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
|
|
goto err;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+ if (atomic_inc_return(&blk_probes_ref) == 1)
|
|
|
|
+ blk_register_tracepoints();
|
|
|
|
+
|
|
return 0;
|
|
return 0;
|
|
-probe_err:
|
|
|
|
- atomic_dec(&blk_probes_ref);
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
err:
|
|
err:
|
|
- if (bt) {
|
|
|
|
- if (bt->msg_file)
|
|
|
|
- debugfs_remove(bt->msg_file);
|
|
|
|
- if (bt->dropped_file)
|
|
|
|
- debugfs_remove(bt->dropped_file);
|
|
|
|
- free_percpu(bt->sequence);
|
|
|
|
- free_percpu(bt->msg_data);
|
|
|
|
- if (bt->rchan)
|
|
|
|
- relay_close(bt->rchan);
|
|
|
|
- kfree(bt);
|
|
|
|
- }
|
|
|
|
|
|
+ blk_trace_free(bt);
|
|
return ret;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -863,7 +861,7 @@ void blk_add_driver_data(struct request_queue *q,
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(blk_add_driver_data);
|
|
EXPORT_SYMBOL_GPL(blk_add_driver_data);
|
|
|
|
|
|
-static int blk_register_tracepoints(void)
|
|
|
|
|
|
+static void blk_register_tracepoints(void)
|
|
{
|
|
{
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
@@ -901,7 +899,6 @@ static int blk_register_tracepoints(void)
|
|
WARN_ON(ret);
|
|
WARN_ON(ret);
|
|
ret = register_trace_block_remap(blk_add_trace_remap);
|
|
ret = register_trace_block_remap(blk_add_trace_remap);
|
|
WARN_ON(ret);
|
|
WARN_ON(ret);
|
|
- return 0;
|
|
|
|
}
|
|
}
|
|
|
|
|
|
static void blk_unregister_tracepoints(void)
|
|
static void blk_unregister_tracepoints(void)
|
|
@@ -934,25 +931,31 @@ static void blk_unregister_tracepoints(void)
|
|
static void fill_rwbs(char *rwbs, const struct blk_io_trace *t)
|
|
static void fill_rwbs(char *rwbs, const struct blk_io_trace *t)
|
|
{
|
|
{
|
|
int i = 0;
|
|
int i = 0;
|
|
|
|
+ int tc = t->action >> BLK_TC_SHIFT;
|
|
|
|
+
|
|
|
|
+ if (t->action == BLK_TN_MESSAGE) {
|
|
|
|
+ rwbs[i++] = 'N';
|
|
|
|
+ goto out;
|
|
|
|
+ }
|
|
|
|
|
|
- if (t->action & BLK_TC_DISCARD)
|
|
|
|
|
|
+ if (tc & BLK_TC_DISCARD)
|
|
rwbs[i++] = 'D';
|
|
rwbs[i++] = 'D';
|
|
- else if (t->action & BLK_TC_WRITE)
|
|
|
|
|
|
+ else if (tc & BLK_TC_WRITE)
|
|
rwbs[i++] = 'W';
|
|
rwbs[i++] = 'W';
|
|
else if (t->bytes)
|
|
else if (t->bytes)
|
|
rwbs[i++] = 'R';
|
|
rwbs[i++] = 'R';
|
|
else
|
|
else
|
|
rwbs[i++] = 'N';
|
|
rwbs[i++] = 'N';
|
|
|
|
|
|
- if (t->action & BLK_TC_AHEAD)
|
|
|
|
|
|
+ if (tc & BLK_TC_AHEAD)
|
|
rwbs[i++] = 'A';
|
|
rwbs[i++] = 'A';
|
|
- if (t->action & BLK_TC_BARRIER)
|
|
|
|
|
|
+ if (tc & BLK_TC_BARRIER)
|
|
rwbs[i++] = 'B';
|
|
rwbs[i++] = 'B';
|
|
- if (t->action & BLK_TC_SYNC)
|
|
|
|
|
|
+ if (tc & BLK_TC_SYNC)
|
|
rwbs[i++] = 'S';
|
|
rwbs[i++] = 'S';
|
|
- if (t->action & BLK_TC_META)
|
|
|
|
|
|
+ if (tc & BLK_TC_META)
|
|
rwbs[i++] = 'M';
|
|
rwbs[i++] = 'M';
|
|
-
|
|
|
|
|
|
+out:
|
|
rwbs[i] = '\0';
|
|
rwbs[i] = '\0';
|
|
}
|
|
}
|
|
|
|
|
|
@@ -979,7 +982,7 @@ static inline unsigned long long t_sector(const struct trace_entry *ent)
|
|
|
|
|
|
static inline __u16 t_error(const struct trace_entry *ent)
|
|
static inline __u16 t_error(const struct trace_entry *ent)
|
|
{
|
|
{
|
|
- return te_blk_io_trace(ent)->sector;
|
|
|
|
|
|
+ return te_blk_io_trace(ent)->error;
|
|
}
|
|
}
|
|
|
|
|
|
static __u64 get_pdu_int(const struct trace_entry *ent)
|
|
static __u64 get_pdu_int(const struct trace_entry *ent)
|
|
@@ -999,29 +1002,31 @@ static void get_pdu_remap(const struct trace_entry *ent,
|
|
r->sector = be64_to_cpu(sector);
|
|
r->sector = be64_to_cpu(sector);
|
|
}
|
|
}
|
|
|
|
|
|
-static int blk_log_action_iter(struct trace_iterator *iter, const char *act)
|
|
|
|
|
|
+typedef int (blk_log_action_t) (struct trace_iterator *iter, const char *act);
|
|
|
|
+
|
|
|
|
+static int blk_log_action_classic(struct trace_iterator *iter, const char *act)
|
|
{
|
|
{
|
|
char rwbs[6];
|
|
char rwbs[6];
|
|
- unsigned long long ts = ns2usecs(iter->ts);
|
|
|
|
- unsigned long usec_rem = do_div(ts, USEC_PER_SEC);
|
|
|
|
|
|
+ unsigned long long ts = iter->ts;
|
|
|
|
+ unsigned long nsec_rem = do_div(ts, NSEC_PER_SEC);
|
|
unsigned secs = (unsigned long)ts;
|
|
unsigned secs = (unsigned long)ts;
|
|
- const struct trace_entry *ent = iter->ent;
|
|
|
|
- const struct blk_io_trace *t = (const struct blk_io_trace *)ent;
|
|
|
|
|
|
+ const struct blk_io_trace *t = te_blk_io_trace(iter->ent);
|
|
|
|
|
|
fill_rwbs(rwbs, t);
|
|
fill_rwbs(rwbs, t);
|
|
|
|
|
|
return trace_seq_printf(&iter->seq,
|
|
return trace_seq_printf(&iter->seq,
|
|
- "%3d,%-3d %2d %5d.%06lu %5u %2s %3s ",
|
|
|
|
|
|
+ "%3d,%-3d %2d %5d.%09lu %5u %2s %3s ",
|
|
MAJOR(t->device), MINOR(t->device), iter->cpu,
|
|
MAJOR(t->device), MINOR(t->device), iter->cpu,
|
|
- secs, usec_rem, ent->pid, act, rwbs);
|
|
|
|
|
|
+ secs, nsec_rem, iter->ent->pid, act, rwbs);
|
|
}
|
|
}
|
|
|
|
|
|
-static int blk_log_action_seq(struct trace_seq *s, const struct blk_io_trace *t,
|
|
|
|
- const char *act)
|
|
|
|
|
|
+static int blk_log_action(struct trace_iterator *iter, const char *act)
|
|
{
|
|
{
|
|
char rwbs[6];
|
|
char rwbs[6];
|
|
|
|
+ const struct blk_io_trace *t = te_blk_io_trace(iter->ent);
|
|
|
|
+
|
|
fill_rwbs(rwbs, t);
|
|
fill_rwbs(rwbs, t);
|
|
- return trace_seq_printf(s, "%3d,%-3d %2s %3s ",
|
|
|
|
|
|
+ return trace_seq_printf(&iter->seq, "%3d,%-3d %2s %3s ",
|
|
MAJOR(t->device), MINOR(t->device), act, rwbs);
|
|
MAJOR(t->device), MINOR(t->device), act, rwbs);
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1085,6 +1090,17 @@ static int blk_log_split(struct trace_seq *s, const struct trace_entry *ent)
|
|
get_pdu_int(ent), cmd);
|
|
get_pdu_int(ent), cmd);
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+static int blk_log_msg(struct trace_seq *s, const struct trace_entry *ent)
|
|
|
|
+{
|
|
|
|
+ int ret;
|
|
|
|
+ const struct blk_io_trace *t = te_blk_io_trace(ent);
|
|
|
|
+
|
|
|
|
+ ret = trace_seq_putmem(s, t + 1, t->pdu_len);
|
|
|
|
+ if (ret)
|
|
|
|
+ return trace_seq_putc(s, '\n');
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
+
|
|
/*
|
|
/*
|
|
* struct tracer operations
|
|
* struct tracer operations
|
|
*/
|
|
*/
|
|
@@ -1099,11 +1115,7 @@ static void blk_tracer_print_header(struct seq_file *m)
|
|
|
|
|
|
static void blk_tracer_start(struct trace_array *tr)
|
|
static void blk_tracer_start(struct trace_array *tr)
|
|
{
|
|
{
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
- if (atomic_add_return(1, &blk_probes_ref) == 1)
|
|
|
|
- if (blk_register_tracepoints())
|
|
|
|
- atomic_dec(&blk_probes_ref);
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
|
|
+ blk_tracer_enabled = true;
|
|
trace_flags &= ~TRACE_ITER_CONTEXT_INFO;
|
|
trace_flags &= ~TRACE_ITER_CONTEXT_INFO;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1111,38 +1123,24 @@ static int blk_tracer_init(struct trace_array *tr)
|
|
{
|
|
{
|
|
blk_tr = tr;
|
|
blk_tr = tr;
|
|
blk_tracer_start(tr);
|
|
blk_tracer_start(tr);
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
- blk_tracer_enabled++;
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
return 0;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
static void blk_tracer_stop(struct trace_array *tr)
|
|
static void blk_tracer_stop(struct trace_array *tr)
|
|
{
|
|
{
|
|
|
|
+ blk_tracer_enabled = false;
|
|
trace_flags |= TRACE_ITER_CONTEXT_INFO;
|
|
trace_flags |= TRACE_ITER_CONTEXT_INFO;
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
- if (atomic_dec_and_test(&blk_probes_ref))
|
|
|
|
- blk_unregister_tracepoints();
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
}
|
|
}
|
|
|
|
|
|
static void blk_tracer_reset(struct trace_array *tr)
|
|
static void blk_tracer_reset(struct trace_array *tr)
|
|
{
|
|
{
|
|
- if (!atomic_read(&blk_probes_ref))
|
|
|
|
- return;
|
|
|
|
-
|
|
|
|
- mutex_lock(&blk_probe_mutex);
|
|
|
|
- blk_tracer_enabled--;
|
|
|
|
- WARN_ON(blk_tracer_enabled < 0);
|
|
|
|
- mutex_unlock(&blk_probe_mutex);
|
|
|
|
-
|
|
|
|
blk_tracer_stop(tr);
|
|
blk_tracer_stop(tr);
|
|
}
|
|
}
|
|
|
|
|
|
-static struct {
|
|
|
|
|
|
+static const struct {
|
|
const char *act[2];
|
|
const char *act[2];
|
|
int (*print)(struct trace_seq *s, const struct trace_entry *ent);
|
|
int (*print)(struct trace_seq *s, const struct trace_entry *ent);
|
|
-} what2act[] __read_mostly = {
|
|
|
|
|
|
+} what2act[] = {
|
|
[__BLK_TA_QUEUE] = {{ "Q", "queue" }, blk_log_generic },
|
|
[__BLK_TA_QUEUE] = {{ "Q", "queue" }, blk_log_generic },
|
|
[__BLK_TA_BACKMERGE] = {{ "M", "backmerge" }, blk_log_generic },
|
|
[__BLK_TA_BACKMERGE] = {{ "M", "backmerge" }, blk_log_generic },
|
|
[__BLK_TA_FRONTMERGE] = {{ "F", "frontmerge" }, blk_log_generic },
|
|
[__BLK_TA_FRONTMERGE] = {{ "F", "frontmerge" }, blk_log_generic },
|
|
@@ -1160,29 +1158,48 @@ static struct {
|
|
[__BLK_TA_REMAP] = {{ "A", "remap" }, blk_log_remap },
|
|
[__BLK_TA_REMAP] = {{ "A", "remap" }, blk_log_remap },
|
|
};
|
|
};
|
|
|
|
|
|
-static enum print_line_t blk_trace_event_print(struct trace_iterator *iter,
|
|
|
|
- int flags)
|
|
|
|
|
|
+static enum print_line_t print_one_line(struct trace_iterator *iter,
|
|
|
|
+ bool classic)
|
|
{
|
|
{
|
|
struct trace_seq *s = &iter->seq;
|
|
struct trace_seq *s = &iter->seq;
|
|
- const struct blk_io_trace *t = (struct blk_io_trace *)iter->ent;
|
|
|
|
- const u16 what = t->action & ((1 << BLK_TC_SHIFT) - 1);
|
|
|
|
|
|
+ const struct blk_io_trace *t;
|
|
|
|
+ u16 what;
|
|
int ret;
|
|
int ret;
|
|
|
|
+ bool long_act;
|
|
|
|
+ blk_log_action_t *log_action;
|
|
|
|
|
|
- if (!trace_print_context(iter))
|
|
|
|
- return TRACE_TYPE_PARTIAL_LINE;
|
|
|
|
|
|
+ t = te_blk_io_trace(iter->ent);
|
|
|
|
+ what = t->action & ((1 << BLK_TC_SHIFT) - 1);
|
|
|
|
+ long_act = !!(trace_flags & TRACE_ITER_VERBOSE);
|
|
|
|
+ log_action = classic ? &blk_log_action_classic : &blk_log_action;
|
|
|
|
|
|
- if (unlikely(what == 0 || what > ARRAY_SIZE(what2act)))
|
|
|
|
|
|
+ if (t->action == BLK_TN_MESSAGE) {
|
|
|
|
+ ret = log_action(iter, long_act ? "message" : "m");
|
|
|
|
+ if (ret)
|
|
|
|
+ ret = blk_log_msg(s, iter->ent);
|
|
|
|
+ goto out;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ if (unlikely(what == 0 || what >= ARRAY_SIZE(what2act)))
|
|
ret = trace_seq_printf(s, "Bad pc action %x\n", what);
|
|
ret = trace_seq_printf(s, "Bad pc action %x\n", what);
|
|
else {
|
|
else {
|
|
- const bool long_act = !!(trace_flags & TRACE_ITER_VERBOSE);
|
|
|
|
- ret = blk_log_action_seq(s, t, what2act[what].act[long_act]);
|
|
|
|
|
|
+ ret = log_action(iter, what2act[what].act[long_act]);
|
|
if (ret)
|
|
if (ret)
|
|
ret = what2act[what].print(s, iter->ent);
|
|
ret = what2act[what].print(s, iter->ent);
|
|
}
|
|
}
|
|
-
|
|
|
|
|
|
+out:
|
|
return ret ? TRACE_TYPE_HANDLED : TRACE_TYPE_PARTIAL_LINE;
|
|
return ret ? TRACE_TYPE_HANDLED : TRACE_TYPE_PARTIAL_LINE;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+static enum print_line_t blk_trace_event_print(struct trace_iterator *iter,
|
|
|
|
+ int flags)
|
|
|
|
+{
|
|
|
|
+ if (!trace_print_context(iter))
|
|
|
|
+ return TRACE_TYPE_PARTIAL_LINE;
|
|
|
|
+
|
|
|
|
+ return print_one_line(iter, false);
|
|
|
|
+}
|
|
|
|
+
|
|
static int blk_trace_synthesize_old_trace(struct trace_iterator *iter)
|
|
static int blk_trace_synthesize_old_trace(struct trace_iterator *iter)
|
|
{
|
|
{
|
|
struct trace_seq *s = &iter->seq;
|
|
struct trace_seq *s = &iter->seq;
|
|
@@ -1190,7 +1207,7 @@ static int blk_trace_synthesize_old_trace(struct trace_iterator *iter)
|
|
const int offset = offsetof(struct blk_io_trace, sector);
|
|
const int offset = offsetof(struct blk_io_trace, sector);
|
|
struct blk_io_trace old = {
|
|
struct blk_io_trace old = {
|
|
.magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION,
|
|
.magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION,
|
|
- .time = ns2usecs(iter->ts),
|
|
|
|
|
|
+ .time = iter->ts,
|
|
};
|
|
};
|
|
|
|
|
|
if (!trace_seq_putmem(s, &old, offset))
|
|
if (!trace_seq_putmem(s, &old, offset))
|
|
@@ -1208,26 +1225,10 @@ blk_trace_event_print_binary(struct trace_iterator *iter, int flags)
|
|
|
|
|
|
static enum print_line_t blk_tracer_print_line(struct trace_iterator *iter)
|
|
static enum print_line_t blk_tracer_print_line(struct trace_iterator *iter)
|
|
{
|
|
{
|
|
- const struct blk_io_trace *t;
|
|
|
|
- u16 what;
|
|
|
|
- int ret;
|
|
|
|
-
|
|
|
|
if (!(blk_tracer_flags.val & TRACE_BLK_OPT_CLASSIC))
|
|
if (!(blk_tracer_flags.val & TRACE_BLK_OPT_CLASSIC))
|
|
return TRACE_TYPE_UNHANDLED;
|
|
return TRACE_TYPE_UNHANDLED;
|
|
|
|
|
|
- t = (const struct blk_io_trace *)iter->ent;
|
|
|
|
- what = t->action & ((1 << BLK_TC_SHIFT) - 1);
|
|
|
|
-
|
|
|
|
- if (unlikely(what == 0 || what > ARRAY_SIZE(what2act)))
|
|
|
|
- ret = trace_seq_printf(&iter->seq, "Bad pc action %x\n", what);
|
|
|
|
- else {
|
|
|
|
- const bool long_act = !!(trace_flags & TRACE_ITER_VERBOSE);
|
|
|
|
- ret = blk_log_action_iter(iter, what2act[what].act[long_act]);
|
|
|
|
- if (ret)
|
|
|
|
- ret = what2act[what].print(&iter->seq, iter->ent);
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
- return ret ? TRACE_TYPE_HANDLED : TRACE_TYPE_PARTIAL_LINE;
|
|
|
|
|
|
+ return print_one_line(iter, true);
|
|
}
|
|
}
|
|
|
|
|
|
static struct tracer blk_tracer __read_mostly = {
|
|
static struct tracer blk_tracer __read_mostly = {
|
|
@@ -1273,7 +1274,10 @@ static int blk_trace_remove_queue(struct request_queue *q)
|
|
if (bt == NULL)
|
|
if (bt == NULL)
|
|
return -EINVAL;
|
|
return -EINVAL;
|
|
|
|
|
|
- kfree(bt);
|
|
|
|
|
|
+ if (atomic_dec_and_test(&blk_probes_ref))
|
|
|
|
+ blk_unregister_tracepoints();
|
|
|
|
+
|
|
|
|
+ blk_trace_free(bt);
|
|
return 0;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1283,26 +1287,33 @@ static int blk_trace_remove_queue(struct request_queue *q)
|
|
static int blk_trace_setup_queue(struct request_queue *q, dev_t dev)
|
|
static int blk_trace_setup_queue(struct request_queue *q, dev_t dev)
|
|
{
|
|
{
|
|
struct blk_trace *old_bt, *bt = NULL;
|
|
struct blk_trace *old_bt, *bt = NULL;
|
|
- int ret;
|
|
|
|
|
|
+ int ret = -ENOMEM;
|
|
|
|
|
|
- ret = -ENOMEM;
|
|
|
|
bt = kzalloc(sizeof(*bt), GFP_KERNEL);
|
|
bt = kzalloc(sizeof(*bt), GFP_KERNEL);
|
|
if (!bt)
|
|
if (!bt)
|
|
- goto err;
|
|
|
|
|
|
+ return -ENOMEM;
|
|
|
|
+
|
|
|
|
+ bt->msg_data = __alloc_percpu(BLK_TN_MAX_MSG, __alignof__(char));
|
|
|
|
+ if (!bt->msg_data)
|
|
|
|
+ goto free_bt;
|
|
|
|
|
|
bt->dev = dev;
|
|
bt->dev = dev;
|
|
bt->act_mask = (u16)-1;
|
|
bt->act_mask = (u16)-1;
|
|
bt->end_lba = -1ULL;
|
|
bt->end_lba = -1ULL;
|
|
- bt->trace_state = Blktrace_running;
|
|
|
|
|
|
|
|
old_bt = xchg(&q->blk_trace, bt);
|
|
old_bt = xchg(&q->blk_trace, bt);
|
|
if (old_bt != NULL) {
|
|
if (old_bt != NULL) {
|
|
(void)xchg(&q->blk_trace, old_bt);
|
|
(void)xchg(&q->blk_trace, old_bt);
|
|
- kfree(bt);
|
|
|
|
ret = -EBUSY;
|
|
ret = -EBUSY;
|
|
|
|
+ goto free_bt;
|
|
}
|
|
}
|
|
|
|
+
|
|
|
|
+ if (atomic_inc_return(&blk_probes_ref) == 1)
|
|
|
|
+ blk_register_tracepoints();
|
|
return 0;
|
|
return 0;
|
|
-err:
|
|
|
|
|
|
+
|
|
|
|
+free_bt:
|
|
|
|
+ blk_trace_free(bt);
|
|
return ret;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1310,72 +1321,6 @@ err:
|
|
* sysfs interface to enable and configure tracing
|
|
* sysfs interface to enable and configure tracing
|
|
*/
|
|
*/
|
|
|
|
|
|
-static ssize_t sysfs_blk_trace_enable_show(struct device *dev,
|
|
|
|
- struct device_attribute *attr,
|
|
|
|
- char *buf)
|
|
|
|
-{
|
|
|
|
- struct hd_struct *p = dev_to_part(dev);
|
|
|
|
- struct block_device *bdev;
|
|
|
|
- ssize_t ret = -ENXIO;
|
|
|
|
-
|
|
|
|
- lock_kernel();
|
|
|
|
- bdev = bdget(part_devt(p));
|
|
|
|
- if (bdev != NULL) {
|
|
|
|
- struct request_queue *q = bdev_get_queue(bdev);
|
|
|
|
-
|
|
|
|
- if (q != NULL) {
|
|
|
|
- mutex_lock(&bdev->bd_mutex);
|
|
|
|
- ret = sprintf(buf, "%u\n", !!q->blk_trace);
|
|
|
|
- mutex_unlock(&bdev->bd_mutex);
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
- bdput(bdev);
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
- unlock_kernel();
|
|
|
|
- return ret;
|
|
|
|
-}
|
|
|
|
-
|
|
|
|
-static ssize_t sysfs_blk_trace_enable_store(struct device *dev,
|
|
|
|
- struct device_attribute *attr,
|
|
|
|
- const char *buf, size_t count)
|
|
|
|
-{
|
|
|
|
- struct block_device *bdev;
|
|
|
|
- struct request_queue *q;
|
|
|
|
- struct hd_struct *p;
|
|
|
|
- int value;
|
|
|
|
- ssize_t ret = -ENXIO;
|
|
|
|
-
|
|
|
|
- if (count == 0 || sscanf(buf, "%d", &value) != 1)
|
|
|
|
- goto out;
|
|
|
|
-
|
|
|
|
- lock_kernel();
|
|
|
|
- p = dev_to_part(dev);
|
|
|
|
- bdev = bdget(part_devt(p));
|
|
|
|
- if (bdev == NULL)
|
|
|
|
- goto out_unlock_kernel;
|
|
|
|
-
|
|
|
|
- q = bdev_get_queue(bdev);
|
|
|
|
- if (q == NULL)
|
|
|
|
- goto out_bdput;
|
|
|
|
-
|
|
|
|
- mutex_lock(&bdev->bd_mutex);
|
|
|
|
- if (value)
|
|
|
|
- ret = blk_trace_setup_queue(q, bdev->bd_dev);
|
|
|
|
- else
|
|
|
|
- ret = blk_trace_remove_queue(q);
|
|
|
|
- mutex_unlock(&bdev->bd_mutex);
|
|
|
|
-
|
|
|
|
- if (ret == 0)
|
|
|
|
- ret = count;
|
|
|
|
-out_bdput:
|
|
|
|
- bdput(bdev);
|
|
|
|
-out_unlock_kernel:
|
|
|
|
- unlock_kernel();
|
|
|
|
-out:
|
|
|
|
- return ret;
|
|
|
|
-}
|
|
|
|
-
|
|
|
|
static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
|
|
static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
|
|
struct device_attribute *attr,
|
|
struct device_attribute *attr,
|
|
char *buf);
|
|
char *buf);
|
|
@@ -1387,8 +1332,7 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
|
|
sysfs_blk_trace_attr_show, \
|
|
sysfs_blk_trace_attr_show, \
|
|
sysfs_blk_trace_attr_store)
|
|
sysfs_blk_trace_attr_store)
|
|
|
|
|
|
-static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR,
|
|
|
|
- sysfs_blk_trace_enable_show, sysfs_blk_trace_enable_store);
|
|
|
|
|
|
+static BLK_TRACE_DEVICE_ATTR(enable);
|
|
static BLK_TRACE_DEVICE_ATTR(act_mask);
|
|
static BLK_TRACE_DEVICE_ATTR(act_mask);
|
|
static BLK_TRACE_DEVICE_ATTR(pid);
|
|
static BLK_TRACE_DEVICE_ATTR(pid);
|
|
static BLK_TRACE_DEVICE_ATTR(start_lba);
|
|
static BLK_TRACE_DEVICE_ATTR(start_lba);
|
|
@@ -1408,53 +1352,85 @@ struct attribute_group blk_trace_attr_group = {
|
|
.attrs = blk_trace_attrs,
|
|
.attrs = blk_trace_attrs,
|
|
};
|
|
};
|
|
|
|
|
|
-static int blk_str2act_mask(const char *str)
|
|
|
|
|
|
+static const struct {
|
|
|
|
+ int mask;
|
|
|
|
+ const char *str;
|
|
|
|
+} mask_maps[] = {
|
|
|
|
+ { BLK_TC_READ, "read" },
|
|
|
|
+ { BLK_TC_WRITE, "write" },
|
|
|
|
+ { BLK_TC_BARRIER, "barrier" },
|
|
|
|
+ { BLK_TC_SYNC, "sync" },
|
|
|
|
+ { BLK_TC_QUEUE, "queue" },
|
|
|
|
+ { BLK_TC_REQUEUE, "requeue" },
|
|
|
|
+ { BLK_TC_ISSUE, "issue" },
|
|
|
|
+ { BLK_TC_COMPLETE, "complete" },
|
|
|
|
+ { BLK_TC_FS, "fs" },
|
|
|
|
+ { BLK_TC_PC, "pc" },
|
|
|
|
+ { BLK_TC_AHEAD, "ahead" },
|
|
|
|
+ { BLK_TC_META, "meta" },
|
|
|
|
+ { BLK_TC_DISCARD, "discard" },
|
|
|
|
+ { BLK_TC_DRV_DATA, "drv_data" },
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+static int blk_trace_str2mask(const char *str)
|
|
{
|
|
{
|
|
|
|
+ int i;
|
|
int mask = 0;
|
|
int mask = 0;
|
|
- char *copy = kstrdup(str, GFP_KERNEL), *s;
|
|
|
|
|
|
+ char *s, *token;
|
|
|
|
|
|
- if (copy == NULL)
|
|
|
|
|
|
+ s = kstrdup(str, GFP_KERNEL);
|
|
|
|
+ if (s == NULL)
|
|
return -ENOMEM;
|
|
return -ENOMEM;
|
|
-
|
|
|
|
- s = strstrip(copy);
|
|
|
|
|
|
+ s = strstrip(s);
|
|
|
|
|
|
while (1) {
|
|
while (1) {
|
|
- char *sep = strchr(s, ',');
|
|
|
|
-
|
|
|
|
- if (sep != NULL)
|
|
|
|
- *sep = '\0';
|
|
|
|
-
|
|
|
|
- if (strcasecmp(s, "barrier") == 0)
|
|
|
|
- mask |= BLK_TC_BARRIER;
|
|
|
|
- else if (strcasecmp(s, "complete") == 0)
|
|
|
|
- mask |= BLK_TC_COMPLETE;
|
|
|
|
- else if (strcasecmp(s, "fs") == 0)
|
|
|
|
- mask |= BLK_TC_FS;
|
|
|
|
- else if (strcasecmp(s, "issue") == 0)
|
|
|
|
- mask |= BLK_TC_ISSUE;
|
|
|
|
- else if (strcasecmp(s, "pc") == 0)
|
|
|
|
- mask |= BLK_TC_PC;
|
|
|
|
- else if (strcasecmp(s, "queue") == 0)
|
|
|
|
- mask |= BLK_TC_QUEUE;
|
|
|
|
- else if (strcasecmp(s, "read") == 0)
|
|
|
|
- mask |= BLK_TC_READ;
|
|
|
|
- else if (strcasecmp(s, "requeue") == 0)
|
|
|
|
- mask |= BLK_TC_REQUEUE;
|
|
|
|
- else if (strcasecmp(s, "sync") == 0)
|
|
|
|
- mask |= BLK_TC_SYNC;
|
|
|
|
- else if (strcasecmp(s, "write") == 0)
|
|
|
|
- mask |= BLK_TC_WRITE;
|
|
|
|
-
|
|
|
|
- if (sep == NULL)
|
|
|
|
|
|
+ token = strsep(&s, ",");
|
|
|
|
+ if (token == NULL)
|
|
break;
|
|
break;
|
|
|
|
|
|
- s = sep + 1;
|
|
|
|
|
|
+ if (*token == '\0')
|
|
|
|
+ continue;
|
|
|
|
+
|
|
|
|
+ for (i = 0; i < ARRAY_SIZE(mask_maps); i++) {
|
|
|
|
+ if (strcasecmp(token, mask_maps[i].str) == 0) {
|
|
|
|
+ mask |= mask_maps[i].mask;
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ if (i == ARRAY_SIZE(mask_maps)) {
|
|
|
|
+ mask = -EINVAL;
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
}
|
|
}
|
|
- kfree(copy);
|
|
|
|
|
|
+ kfree(s);
|
|
|
|
|
|
return mask;
|
|
return mask;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+static ssize_t blk_trace_mask2str(char *buf, int mask)
|
|
|
|
+{
|
|
|
|
+ int i;
|
|
|
|
+ char *p = buf;
|
|
|
|
+
|
|
|
|
+ for (i = 0; i < ARRAY_SIZE(mask_maps); i++) {
|
|
|
|
+ if (mask & mask_maps[i].mask) {
|
|
|
|
+ p += sprintf(p, "%s%s",
|
|
|
|
+ (p == buf) ? "" : ",", mask_maps[i].str);
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ *p++ = '\n';
|
|
|
|
+
|
|
|
|
+ return p - buf;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static struct request_queue *blk_trace_get_queue(struct block_device *bdev)
|
|
|
|
+{
|
|
|
|
+ if (bdev->bd_disk == NULL)
|
|
|
|
+ return NULL;
|
|
|
|
+
|
|
|
|
+ return bdev_get_queue(bdev);
|
|
|
|
+}
|
|
|
|
+
|
|
static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
|
|
static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
|
|
struct device_attribute *attr,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
char *buf)
|
|
@@ -1469,20 +1445,29 @@ static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
|
|
if (bdev == NULL)
|
|
if (bdev == NULL)
|
|
goto out_unlock_kernel;
|
|
goto out_unlock_kernel;
|
|
|
|
|
|
- q = bdev_get_queue(bdev);
|
|
|
|
|
|
+ q = blk_trace_get_queue(bdev);
|
|
if (q == NULL)
|
|
if (q == NULL)
|
|
goto out_bdput;
|
|
goto out_bdput;
|
|
|
|
+
|
|
mutex_lock(&bdev->bd_mutex);
|
|
mutex_lock(&bdev->bd_mutex);
|
|
|
|
+
|
|
|
|
+ if (attr == &dev_attr_enable) {
|
|
|
|
+ ret = sprintf(buf, "%u\n", !!q->blk_trace);
|
|
|
|
+ goto out_unlock_bdev;
|
|
|
|
+ }
|
|
|
|
+
|
|
if (q->blk_trace == NULL)
|
|
if (q->blk_trace == NULL)
|
|
ret = sprintf(buf, "disabled\n");
|
|
ret = sprintf(buf, "disabled\n");
|
|
else if (attr == &dev_attr_act_mask)
|
|
else if (attr == &dev_attr_act_mask)
|
|
- ret = sprintf(buf, "%#x\n", q->blk_trace->act_mask);
|
|
|
|
|
|
+ ret = blk_trace_mask2str(buf, q->blk_trace->act_mask);
|
|
else if (attr == &dev_attr_pid)
|
|
else if (attr == &dev_attr_pid)
|
|
ret = sprintf(buf, "%u\n", q->blk_trace->pid);
|
|
ret = sprintf(buf, "%u\n", q->blk_trace->pid);
|
|
else if (attr == &dev_attr_start_lba)
|
|
else if (attr == &dev_attr_start_lba)
|
|
ret = sprintf(buf, "%llu\n", q->blk_trace->start_lba);
|
|
ret = sprintf(buf, "%llu\n", q->blk_trace->start_lba);
|
|
else if (attr == &dev_attr_end_lba)
|
|
else if (attr == &dev_attr_end_lba)
|
|
ret = sprintf(buf, "%llu\n", q->blk_trace->end_lba);
|
|
ret = sprintf(buf, "%llu\n", q->blk_trace->end_lba);
|
|
|
|
+
|
|
|
|
+out_unlock_bdev:
|
|
mutex_unlock(&bdev->bd_mutex);
|
|
mutex_unlock(&bdev->bd_mutex);
|
|
out_bdput:
|
|
out_bdput:
|
|
bdput(bdev);
|
|
bdput(bdev);
|
|
@@ -1499,7 +1484,7 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
|
|
struct request_queue *q;
|
|
struct request_queue *q;
|
|
struct hd_struct *p;
|
|
struct hd_struct *p;
|
|
u64 value;
|
|
u64 value;
|
|
- ssize_t ret = -ENXIO;
|
|
|
|
|
|
+ ssize_t ret = -EINVAL;
|
|
|
|
|
|
if (count == 0)
|
|
if (count == 0)
|
|
goto out;
|
|
goto out;
|
|
@@ -1507,24 +1492,36 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
|
|
if (attr == &dev_attr_act_mask) {
|
|
if (attr == &dev_attr_act_mask) {
|
|
if (sscanf(buf, "%llx", &value) != 1) {
|
|
if (sscanf(buf, "%llx", &value) != 1) {
|
|
/* Assume it is a list of trace category names */
|
|
/* Assume it is a list of trace category names */
|
|
- value = blk_str2act_mask(buf);
|
|
|
|
- if (value < 0)
|
|
|
|
|
|
+ ret = blk_trace_str2mask(buf);
|
|
|
|
+ if (ret < 0)
|
|
goto out;
|
|
goto out;
|
|
|
|
+ value = ret;
|
|
}
|
|
}
|
|
} else if (sscanf(buf, "%llu", &value) != 1)
|
|
} else if (sscanf(buf, "%llu", &value) != 1)
|
|
goto out;
|
|
goto out;
|
|
|
|
|
|
|
|
+ ret = -ENXIO;
|
|
|
|
+
|
|
lock_kernel();
|
|
lock_kernel();
|
|
p = dev_to_part(dev);
|
|
p = dev_to_part(dev);
|
|
bdev = bdget(part_devt(p));
|
|
bdev = bdget(part_devt(p));
|
|
if (bdev == NULL)
|
|
if (bdev == NULL)
|
|
goto out_unlock_kernel;
|
|
goto out_unlock_kernel;
|
|
|
|
|
|
- q = bdev_get_queue(bdev);
|
|
|
|
|
|
+ q = blk_trace_get_queue(bdev);
|
|
if (q == NULL)
|
|
if (q == NULL)
|
|
goto out_bdput;
|
|
goto out_bdput;
|
|
|
|
|
|
mutex_lock(&bdev->bd_mutex);
|
|
mutex_lock(&bdev->bd_mutex);
|
|
|
|
+
|
|
|
|
+ if (attr == &dev_attr_enable) {
|
|
|
|
+ if (value)
|
|
|
|
+ ret = blk_trace_setup_queue(q, bdev->bd_dev);
|
|
|
|
+ else
|
|
|
|
+ ret = blk_trace_remove_queue(q);
|
|
|
|
+ goto out_unlock_bdev;
|
|
|
|
+ }
|
|
|
|
+
|
|
ret = 0;
|
|
ret = 0;
|
|
if (q->blk_trace == NULL)
|
|
if (q->blk_trace == NULL)
|
|
ret = blk_trace_setup_queue(q, bdev->bd_dev);
|
|
ret = blk_trace_setup_queue(q, bdev->bd_dev);
|
|
@@ -1538,13 +1535,15 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
|
|
q->blk_trace->start_lba = value;
|
|
q->blk_trace->start_lba = value;
|
|
else if (attr == &dev_attr_end_lba)
|
|
else if (attr == &dev_attr_end_lba)
|
|
q->blk_trace->end_lba = value;
|
|
q->blk_trace->end_lba = value;
|
|
- ret = count;
|
|
|
|
}
|
|
}
|
|
|
|
+
|
|
|
|
+out_unlock_bdev:
|
|
mutex_unlock(&bdev->bd_mutex);
|
|
mutex_unlock(&bdev->bd_mutex);
|
|
out_bdput:
|
|
out_bdput:
|
|
bdput(bdev);
|
|
bdput(bdev);
|
|
out_unlock_kernel:
|
|
out_unlock_kernel:
|
|
unlock_kernel();
|
|
unlock_kernel();
|
|
out:
|
|
out:
|
|
- return ret;
|
|
|
|
|
|
+ return ret ? ret : count;
|
|
}
|
|
}
|
|
|
|
+
|