瀏覽代碼

[PATCH] hostap: Fix double free in prism2_config() error path

The Coverity checker (CID: 930) spotted this double free on error path
(allocation failure). Do not free these here since generic error path
will take care of this.

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Jouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Eugene Teo 19 年之前
父節點
當前提交
8abceaf1cf
共有 1 個文件被更改,包括 0 次插入2 次删除
  1. 0 2
      drivers/net/wireless/hostap/hostap_cs.c

+ 0 - 2
drivers/net/wireless/hostap/hostap_cs.c

@@ -585,8 +585,6 @@ static int prism2_config(dev_link_t *link)
 	parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL);
 	parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL);
 	hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL);
 	hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL);
 	if (parse == NULL || hw_priv == NULL) {
 	if (parse == NULL || hw_priv == NULL) {
-		kfree(parse);
-		kfree(hw_priv);
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto failed;
 		goto failed;
 	}
 	}