浏览代码

mfd: Set adp5520 bits if new value is different from the old one

Current code checks if all the bit_mask bits are all zero is wrong.
We need to write new value if the bit mask fields of new value is
not equal to old value.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Axel Lin 13 年之前
父节点
当前提交
890c98e374
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/mfd/adp5520.c

+ 1 - 1
drivers/mfd/adp5520.c

@@ -109,7 +109,7 @@ int adp5520_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 
 
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 
 
-	if (!ret && ((reg_val & bit_mask) == 0)) {
+	if (!ret && ((reg_val & bit_mask) != bit_mask)) {
 		reg_val |= bit_mask;
 		reg_val |= bit_mask;
 		ret = __adp5520_write(chip->client, reg, reg_val);
 		ret = __adp5520_write(chip->client, reg, reg_val);
 	}
 	}