Browse Source

usb: gadget: renesas_usbhs: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Thomas Meyer 13 năm trước cách đây
mục cha
commit
87763842b7
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/usb/renesas_usbhs/mod_host.c

+ 1 - 1
drivers/usb/renesas_usbhs/mod_host.c

@@ -1268,7 +1268,7 @@ int usbhs_mod_host_probe(struct usbhs_priv *priv)
 		return -ENOMEM;
 	}
 
-	pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL);
+	pipe_info = kcalloc(pipe_size, sizeof(*pipe_info), GFP_KERNEL);
 	if (!pipe_info) {
 		dev_err(dev, "Could not allocate pipe_info\n");
 		goto usbhs_mod_host_probe_err;