Selaa lähdekoodia

can: ti_hecc: Fix uninitialized spinlock in probe

In ti_hecc_probe(), the spinlock  priv->mbx_lock is not
inited, causing a spinlock lockup BUG.

Acked-by: Anant Gole <anantgole@ti.com>
Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Abhilash K V 14 vuotta sitten
vanhempi
commit
86ad47fff9
1 muutettua tiedostoa jossa 1 lisäystä ja 0 poistoa
  1. 1 0
      drivers/net/can/ti_hecc.c

+ 1 - 0
drivers/net/can/ti_hecc.c

@@ -923,6 +923,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
 	priv->can.do_get_state = ti_hecc_get_state;
 	priv->can.do_get_state = ti_hecc_get_state;
 	priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
 	priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
 
 
+	spin_lock_init(&priv->mbx_lock);
 	ndev->irq = irq->start;
 	ndev->irq = irq->start;
 	ndev->flags |= IFF_ECHO;
 	ndev->flags |= IFF_ECHO;
 	platform_set_drvdata(pdev, ndev);
 	platform_set_drvdata(pdev, ndev);