|
@@ -125,24 +125,6 @@ static void ath_tx_queue_tid(struct ath_txq *txq, struct ath_atx_tid *tid)
|
|
|
list_add_tail(&ac->list, &txq->axq_acq);
|
|
|
}
|
|
|
|
|
|
-static void ath_tx_resume_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
|
|
|
-{
|
|
|
- struct ath_txq *txq = tid->ac->txq;
|
|
|
-
|
|
|
- WARN_ON(!tid->paused);
|
|
|
-
|
|
|
- ath_txq_lock(sc, txq);
|
|
|
- tid->paused = false;
|
|
|
-
|
|
|
- if (skb_queue_empty(&tid->buf_q))
|
|
|
- goto unlock;
|
|
|
-
|
|
|
- ath_tx_queue_tid(txq, tid);
|
|
|
- ath_txq_schedule(sc, txq);
|
|
|
-unlock:
|
|
|
- ath_txq_unlock_complete(sc, txq);
|
|
|
-}
|
|
|
-
|
|
|
static struct ath_frame_info *get_frame_info(struct sk_buff *skb)
|
|
|
{
|
|
|
struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
|
|
@@ -201,11 +183,6 @@ static void ath_tx_flush_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
|
|
|
}
|
|
|
}
|
|
|
|
|
|
- if (tid->baw_head == tid->baw_tail) {
|
|
|
- tid->state &= ~AGGR_ADDBA_COMPLETE;
|
|
|
- tid->state &= ~AGGR_CLEANUP;
|
|
|
- }
|
|
|
-
|
|
|
if (sendbar) {
|
|
|
ath_txq_unlock(sc, txq);
|
|
|
ath_send_bar(tid, tid->seq_start);
|
|
@@ -277,9 +254,7 @@ static void ath_tid_drain(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
|
|
|
list_add_tail(&bf->list, &bf_head);
|
|
|
|
|
|
- if (fi->retries)
|
|
|
- ath_tx_update_baw(sc, tid, bf->bf_state.seqno);
|
|
|
-
|
|
|
+ ath_tx_update_baw(sc, tid, bf->bf_state.seqno);
|
|
|
ath_tx_complete_buf(sc, bf, txq, &bf_head, &ts, 0);
|
|
|
}
|
|
|
|
|
@@ -491,19 +466,19 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
tx_info = IEEE80211_SKB_CB(skb);
|
|
|
fi = get_frame_info(skb);
|
|
|
|
|
|
- if (ATH_BA_ISSET(ba, ATH_BA_INDEX(seq_st, seqno))) {
|
|
|
+ if (!BAW_WITHIN(tid->seq_start, tid->baw_size, seqno)) {
|
|
|
+ /*
|
|
|
+ * Outside of the current BlockAck window,
|
|
|
+ * maybe part of a previous session
|
|
|
+ */
|
|
|
+ txfail = 1;
|
|
|
+ } else if (ATH_BA_ISSET(ba, ATH_BA_INDEX(seq_st, seqno))) {
|
|
|
/* transmit completion, subframe is
|
|
|
* acked by block ack */
|
|
|
acked_cnt++;
|
|
|
} else if (!isaggr && txok) {
|
|
|
/* transmit completion */
|
|
|
acked_cnt++;
|
|
|
- } else if (tid->state & AGGR_CLEANUP) {
|
|
|
- /*
|
|
|
- * cleanup in progress, just fail
|
|
|
- * the un-acked sub-frames
|
|
|
- */
|
|
|
- txfail = 1;
|
|
|
} else if (flush) {
|
|
|
txpending = 1;
|
|
|
} else if (fi->retries < ATH_MAX_SW_RETRIES) {
|
|
@@ -527,7 +502,7 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
if (bf_next != NULL || !bf_last->bf_stale)
|
|
|
list_move_tail(&bf->list, &bf_head);
|
|
|
|
|
|
- if (!txpending || (tid->state & AGGR_CLEANUP)) {
|
|
|
+ if (!txpending) {
|
|
|
/*
|
|
|
* complete the acked-ones/xretried ones; update
|
|
|
* block-ack window
|
|
@@ -601,9 +576,6 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
ath_txq_lock(sc, txq);
|
|
|
}
|
|
|
|
|
|
- if (tid->state & AGGR_CLEANUP)
|
|
|
- ath_tx_flush_tid(sc, tid);
|
|
|
-
|
|
|
rcu_read_unlock();
|
|
|
|
|
|
if (needreset)
|
|
@@ -620,6 +592,7 @@ static void ath_tx_process_buffer(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
struct ath_tx_status *ts, struct ath_buf *bf,
|
|
|
struct list_head *bf_head)
|
|
|
{
|
|
|
+ struct ieee80211_tx_info *info;
|
|
|
bool txok, flush;
|
|
|
|
|
|
txok = !(ts->ts_status & ATH9K_TXERR_MASK);
|
|
@@ -631,8 +604,12 @@ static void ath_tx_process_buffer(struct ath_softc *sc, struct ath_txq *txq,
|
|
|
txq->axq_ampdu_depth--;
|
|
|
|
|
|
if (!bf_isampdu(bf)) {
|
|
|
- if (!flush)
|
|
|
+ if (!flush) {
|
|
|
+ info = IEEE80211_SKB_CB(bf->bf_mpdu);
|
|
|
+ memcpy(info->control.rates, bf->rates,
|
|
|
+ sizeof(info->control.rates));
|
|
|
ath_tx_rc_status(sc, bf, ts, 1, txok ? 0 : 1, txok);
|
|
|
+ }
|
|
|
ath_tx_complete_buf(sc, bf, txq, bf_head, ts, txok);
|
|
|
} else
|
|
|
ath_tx_complete_aggr(sc, txq, bf, bf_head, ts, txok);
|
|
@@ -676,7 +653,7 @@ static u32 ath_lookup_rate(struct ath_softc *sc, struct ath_buf *bf,
|
|
|
|
|
|
skb = bf->bf_mpdu;
|
|
|
tx_info = IEEE80211_SKB_CB(skb);
|
|
|
- rates = tx_info->control.rates;
|
|
|
+ rates = bf->rates;
|
|
|
|
|
|
/*
|
|
|
* Find the lowest frame length among the rate series that will have a
|
|
@@ -1231,9 +1208,6 @@ int ath_tx_aggr_start(struct ath_softc *sc, struct ieee80211_sta *sta,
|
|
|
an = (struct ath_node *)sta->drv_priv;
|
|
|
txtid = ATH_AN_2_TID(an, tid);
|
|
|
|
|
|
- if (txtid->state & (AGGR_CLEANUP | AGGR_ADDBA_COMPLETE))
|
|
|
- return -EAGAIN;
|
|
|
-
|
|
|
/* update ampdu factor/density, they may have changed. This may happen
|
|
|
* in HT IBSS when a beacon with HT-info is received after the station
|
|
|
* has already been added.
|
|
@@ -1245,7 +1219,7 @@ int ath_tx_aggr_start(struct ath_softc *sc, struct ieee80211_sta *sta,
|
|
|
an->mpdudensity = density;
|
|
|
}
|
|
|
|
|
|
- txtid->state |= AGGR_ADDBA_PROGRESS;
|
|
|
+ txtid->active = true;
|
|
|
txtid->paused = true;
|
|
|
*ssn = txtid->seq_start = txtid->seq_next;
|
|
|
txtid->bar_index = -1;
|
|
@@ -1262,28 +1236,9 @@ void ath_tx_aggr_stop(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid)
|
|
|
struct ath_atx_tid *txtid = ATH_AN_2_TID(an, tid);
|
|
|
struct ath_txq *txq = txtid->ac->txq;
|
|
|
|
|
|
- if (txtid->state & AGGR_CLEANUP)
|
|
|
- return;
|
|
|
-
|
|
|
- if (!(txtid->state & AGGR_ADDBA_COMPLETE)) {
|
|
|
- txtid->state &= ~AGGR_ADDBA_PROGRESS;
|
|
|
- return;
|
|
|
- }
|
|
|
-
|
|
|
ath_txq_lock(sc, txq);
|
|
|
+ txtid->active = false;
|
|
|
txtid->paused = true;
|
|
|
-
|
|
|
- /*
|
|
|
- * If frames are still being transmitted for this TID, they will be
|
|
|
- * cleaned up during tx completion. To prevent race conditions, this
|
|
|
- * TID can only be reused after all in-progress subframes have been
|
|
|
- * completed.
|
|
|
- */
|
|
|
- if (txtid->baw_head != txtid->baw_tail)
|
|
|
- txtid->state |= AGGR_CLEANUP;
|
|
|
- else
|
|
|
- txtid->state &= ~AGGR_ADDBA_COMPLETE;
|
|
|
-
|
|
|
ath_tx_flush_tid(sc, txtid);
|
|
|
ath_txq_unlock_complete(sc, txq);
|
|
|
}
|
|
@@ -1349,18 +1304,28 @@ void ath_tx_aggr_wakeup(struct ath_softc *sc, struct ath_node *an)
|
|
|
}
|
|
|
}
|
|
|
|
|
|
-void ath_tx_aggr_resume(struct ath_softc *sc, struct ieee80211_sta *sta, u16 tid)
|
|
|
+void ath_tx_aggr_resume(struct ath_softc *sc, struct ieee80211_sta *sta,
|
|
|
+ u16 tidno)
|
|
|
{
|
|
|
- struct ath_atx_tid *txtid;
|
|
|
+ struct ath_atx_tid *tid;
|
|
|
struct ath_node *an;
|
|
|
+ struct ath_txq *txq;
|
|
|
|
|
|
an = (struct ath_node *)sta->drv_priv;
|
|
|
+ tid = ATH_AN_2_TID(an, tidno);
|
|
|
+ txq = tid->ac->txq;
|
|
|
|
|
|
- txtid = ATH_AN_2_TID(an, tid);
|
|
|
- txtid->baw_size = IEEE80211_MIN_AMPDU_BUF << sta->ht_cap.ampdu_factor;
|
|
|
- txtid->state |= AGGR_ADDBA_COMPLETE;
|
|
|
- txtid->state &= ~AGGR_ADDBA_PROGRESS;
|
|
|
- ath_tx_resume_tid(sc, txtid);
|
|
|
+ ath_txq_lock(sc, txq);
|
|
|
+
|
|
|
+ tid->baw_size = IEEE80211_MIN_AMPDU_BUF << sta->ht_cap.ampdu_factor;
|
|
|
+ tid->paused = false;
|
|
|
+
|
|
|
+ if (!skb_queue_empty(&tid->buf_q)) {
|
|
|
+ ath_tx_queue_tid(txq, tid);
|
|
|
+ ath_txq_schedule(sc, txq);
|
|
|
+ }
|
|
|
+
|
|
|
+ ath_txq_unlock_complete(sc, txq);
|
|
|
}
|
|
|
|
|
|
/********************/
|
|
@@ -2409,12 +2374,10 @@ void ath_tx_node_init(struct ath_softc *sc, struct ath_node *an)
|
|
|
tid->baw_head = tid->baw_tail = 0;
|
|
|
tid->sched = false;
|
|
|
tid->paused = false;
|
|
|
- tid->state &= ~AGGR_CLEANUP;
|
|
|
+ tid->active = false;
|
|
|
__skb_queue_head_init(&tid->buf_q);
|
|
|
acno = TID_TO_WME_AC(tidno);
|
|
|
tid->ac = &an->ac[acno];
|
|
|
- tid->state &= ~AGGR_ADDBA_COMPLETE;
|
|
|
- tid->state &= ~AGGR_ADDBA_PROGRESS;
|
|
|
}
|
|
|
|
|
|
for (acno = 0, ac = &an->ac[acno];
|
|
@@ -2451,8 +2414,7 @@ void ath_tx_node_cleanup(struct ath_softc *sc, struct ath_node *an)
|
|
|
}
|
|
|
|
|
|
ath_tid_drain(sc, txq, tid);
|
|
|
- tid->state &= ~AGGR_ADDBA_COMPLETE;
|
|
|
- tid->state &= ~AGGR_CLEANUP;
|
|
|
+ tid->active = false;
|
|
|
|
|
|
ath_txq_unlock(sc, txq);
|
|
|
}
|