瀏覽代碼

[IPVS]: Relax the module get/put in ip_vs_app.c

Both try_module_get/module_put already handle the module == NULL
case, so no need in manual checking.

This patch fits both net-2.6 and net-2.6.25.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Pavel Emelyanov 17 年之前
父節點
當前提交
85b606800b
共有 1 個文件被更改,包括 2 次插入7 次删除
  1. 2 7
      net/ipv4/ipvs/ip_vs_app.c

+ 2 - 7
net/ipv4/ipvs/ip_vs_app.c

@@ -51,18 +51,13 @@ static DEFINE_MUTEX(__ip_vs_app_mutex);
  */
  */
 static inline int ip_vs_app_get(struct ip_vs_app *app)
 static inline int ip_vs_app_get(struct ip_vs_app *app)
 {
 {
-	/* test and get the module atomically */
-	if (app->module)
-		return try_module_get(app->module);
-	else
-		return 1;
+	return try_module_get(app->module);
 }
 }
 
 
 
 
 static inline void ip_vs_app_put(struct ip_vs_app *app)
 static inline void ip_vs_app_put(struct ip_vs_app *app)
 {
 {
-	if (app->module)
-		module_put(app->module);
+	module_put(app->module);
 }
 }