Quellcode durchsuchen

jz4740-battery: Check if platform_data is supplied

Currently platform_data is dereferenced without checking whether it
is actually set, which can lead to kernel crashes.
This patch adds a check which will abort the drivers probe function
gracefully if no platform_data is supplied.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Lars-Peter Clausen vor 14 Jahren
Ursprung
Commit
8477cedb49
1 geänderte Dateien mit 5 neuen und 0 gelöschten Zeilen
  1. 5 0
      drivers/power/jz4740-battery.c

+ 5 - 0
drivers/power/jz4740-battery.c

@@ -246,6 +246,11 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
 	struct jz_battery *jz_battery;
 	struct power_supply *battery;
 
+	if (!pdata) {
+		dev_err(&pdev->dev, "No platform_data supplied\n");
+		return -ENXIO;
+	}
+
 	jz_battery = kzalloc(sizeof(*jz_battery), GFP_KERNEL);
 	if (!jz_battery) {
 		dev_err(&pdev->dev, "Failed to allocate driver structure\n");