瀏覽代碼

V4L/DVB (9173): S2API: Remove the hardcoded command limit during validation

This means that when developers add new commands then they'll be see
the DTV_MAX_COMMAND define and will be more likely to modify it, without
having to modify the command validation code.

Signed-off-by: Steven Toth <stoth@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Steven Toth 16 年之前
父節點
當前提交
82d7669dc3
共有 2 個文件被更改,包括 3 次插入2 次删除
  1. 1 2
      drivers/media/dvb/dvb-core/dvb_frontend.c
  2. 2 0
      include/linux/dvb/frontend.h

+ 1 - 2
drivers/media/dvb/dvb-core/dvb_frontend.c

@@ -848,8 +848,7 @@ void dtv_property_dump(struct dtv_property *tvp)
 {
 	int i;
 
-	if( (tvp->cmd <= 0 || tvp->cmd > DTV_DELIVERY_SYSTEM) &&
-			tvp->cmd != DTV_API_VERSION) {
+	if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) {
 		printk("%s: tvp.cmd = 0x%08x (undefined/unknown/invalid)\n",
 			__func__, tvp->cmd);
 		return;

+ 2 - 0
include/linux/dvb/frontend.h

@@ -270,6 +270,8 @@ struct dvb_frontend_event {
 
 #define DTV_API_VERSION				35
 
+#define DTV_MAX_COMMAND				DTV_API_VERSION
+
 typedef enum fe_pilot {
 	PILOT_ON,
 	PILOT_OFF,