Browse Source

drivers/net/wimax/i2400m/fw.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret;
expression e1,e2;
@@

if (ret < 0)
 { ... return ret; }
 ... when != ret = e1
     when forall
*if(...)
 {
  ... when != ret = e2
* return ret;
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Julia Lawall 13 years ago
parent
commit
82a820e8d7
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/net/wimax/i2400m/fw.c

+ 3 - 1
drivers/net/wimax/i2400m/fw.c

@@ -326,8 +326,10 @@ int i2400m_barker_db_init(const char *_options)
 		unsigned barker;
 		unsigned barker;
 
 
 		options_orig = kstrdup(_options, GFP_KERNEL);
 		options_orig = kstrdup(_options, GFP_KERNEL);
-		if (options_orig == NULL)
+		if (options_orig == NULL) {
+			result = -ENOMEM;
 			goto error_parse;
 			goto error_parse;
+		}
 		options = options_orig;
 		options = options_orig;
 
 
 		while ((token = strsep(&options, ",")) != NULL) {
 		while ((token = strsep(&options, ",")) != NULL) {