瀏覽代碼

[PATCH] kdump: i386 save ss esp bug fix

)

From: Vivek Goyal <vgoyal@in.ibm.com>

This patch fixes a minor bug based on Andi Kleen's suggestion.  asm's can't be
broken in this particular case, hence merging them.

Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
akpm@osdl.org 19 年之前
父節點
當前提交
8240941157
共有 1 個文件被更改,包括 4 次插入2 次删除
  1. 4 2
      arch/i386/kernel/crash.c

+ 4 - 2
arch/i386/kernel/crash.c

@@ -108,8 +108,10 @@ static void crash_setup_regs(struct pt_regs *newregs, struct pt_regs *oldregs)
 {
 {
 	memcpy(newregs, oldregs, sizeof(*newregs));
 	memcpy(newregs, oldregs, sizeof(*newregs));
 	newregs->esp = (unsigned long)&(oldregs->esp);
 	newregs->esp = (unsigned long)&(oldregs->esp);
-	__asm__ __volatile__("xorl %eax, %eax;");
-	__asm__ __volatile__ ("movw %%ss, %%ax;" :"=a"(newregs->xss));
+	__asm__ __volatile__(
+			"xorl %%eax, %%eax\n\t"
+			"movw %%ss, %%ax\n\t"
+			:"=a"(newregs->xss));
 }
 }
 
 
 /* We may have saved_regs from where the error came from
 /* We may have saved_regs from where the error came from