Browse Source

KVM: Keep control regs in sync

We don't update the vcpu control registers in various places.  We
should do so.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Rusty Russell 18 years ago
parent
commit
81f50e3bfd
1 changed files with 4 additions and 4 deletions
  1. 4 4
      drivers/kvm/kvm_main.c

+ 4 - 4
drivers/kvm/kvm_main.c

@@ -543,6 +543,7 @@ void set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
 		return;
 		return;
 	}
 	}
 	kvm_arch_ops->set_cr4(vcpu, cr4);
 	kvm_arch_ops->set_cr4(vcpu, cr4);
+	vcpu->cr4 = cr4;
 	mutex_lock(&vcpu->kvm->lock);
 	mutex_lock(&vcpu->kvm->lock);
 	kvm_mmu_reset_context(vcpu);
 	kvm_mmu_reset_context(vcpu);
 	mutex_unlock(&vcpu->kvm->lock);
 	mutex_unlock(&vcpu->kvm->lock);
@@ -1238,10 +1239,8 @@ int emulate_invlpg(struct kvm_vcpu *vcpu, gva_t address)
 
 
 int emulate_clts(struct kvm_vcpu *vcpu)
 int emulate_clts(struct kvm_vcpu *vcpu)
 {
 {
-	unsigned long cr0;
-
-	cr0 = vcpu->cr0 & ~X86_CR0_TS;
-	kvm_arch_ops->set_cr0(vcpu, cr0);
+	vcpu->cr0 &= ~X86_CR0_TS;
+	kvm_arch_ops->set_cr0(vcpu, vcpu->cr0);
 	return X86EMUL_CONTINUE;
 	return X86EMUL_CONTINUE;
 }
 }
 
 
@@ -2226,6 +2225,7 @@ static int kvm_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu,
 	kvm_arch_ops->decache_cr4_guest_bits(vcpu);
 	kvm_arch_ops->decache_cr4_guest_bits(vcpu);
 
 
 	mmu_reset_needed |= vcpu->cr0 != sregs->cr0;
 	mmu_reset_needed |= vcpu->cr0 != sregs->cr0;
+	vcpu->cr0 = sregs->cr0;
 	kvm_arch_ops->set_cr0(vcpu, sregs->cr0);
 	kvm_arch_ops->set_cr0(vcpu, sregs->cr0);
 
 
 	mmu_reset_needed |= vcpu->cr4 != sregs->cr4;
 	mmu_reset_needed |= vcpu->cr4 != sregs->cr4;