فهرست منبع

module: remove over-zealous check in __module_get()

Impact: fix spurious BUG_ON() triggered under load

module_refcount() isn't reliable outside stop_machine(), as demonstrated
by Karsten Keil <kkeil@suse.de>, networking can trigger it under load
(an inc on one cpu and dec on another while module_refcount() is tallying
 can give false results, for example).

Almost noone should be using __module_get, but that's another issue.

Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Rusty Russell 16 سال پیش
والد
کامیت
7f9a50a5b8
1فایلهای تغییر یافته به همراه0 افزوده شده و 1 حذف شده
  1. 0 1
      include/linux/module.h

+ 0 - 1
include/linux/module.h

@@ -407,7 +407,6 @@ static inline local_t *__module_ref_addr(struct module *mod, int cpu)
 static inline void __module_get(struct module *module)
 static inline void __module_get(struct module *module)
 {
 {
 	if (module) {
 	if (module) {
-		BUG_ON(module_refcount(module) == 0);
 		local_inc(__module_ref_addr(module, get_cpu()));
 		local_inc(__module_ref_addr(module, get_cpu()));
 		put_cpu();
 		put_cpu();
 	}
 	}