Browse Source

[ATM]: [he] don't hold the device lock when upcalling

This can create a deadlock/lock ordering problem with other layers
that want to use the transmit (or other) path of the card at that
time.

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
Chas Williams 18 years ago
parent
commit
7f81dc0097
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/atm/he.c

+ 2 - 0
drivers/atm/he.c

@@ -1928,7 +1928,9 @@ he_service_rbrq(struct he_dev *he_dev, int group)
 #ifdef notdef
 #ifdef notdef
 		ATM_SKB(skb)->vcc = vcc;
 		ATM_SKB(skb)->vcc = vcc;
 #endif
 #endif
+		spin_unlock(&he_dev->global_lock);
 		vcc->push(vcc, skb);
 		vcc->push(vcc, skb);
+		spin_lock(&he_dev->global_lock);
 
 
 		atomic_inc(&vcc->stats->rx);
 		atomic_inc(&vcc->stats->rx);