Kaynağa Gözat

[PATCH] i2c: Optimize core_lists mutex usage

Stop holding the core_lists mutex when we don't actually need it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jean Delvare 19 yıl önce
ebeveyn
işleme
7eebcb7c0f
1 değiştirilmiş dosya ile 5 ekleme ve 6 silme
  1. 5 6
      drivers/i2c/i2c-core.c

+ 5 - 6
drivers/i2c/i2c-core.c

@@ -288,9 +288,7 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 {
 {
 	struct list_head   *item;
 	struct list_head   *item;
 	struct i2c_adapter *adapter;
 	struct i2c_adapter *adapter;
-	int res = 0;
-
-	mutex_lock(&core_lists);
+	int res;
 
 
 	/* add the driver to the list of i2c drivers in the driver core */
 	/* add the driver to the list of i2c drivers in the driver core */
 	driver->driver.owner = owner;
 	driver->driver.owner = owner;
@@ -298,8 +296,10 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 
 
 	res = driver_register(&driver->driver);
 	res = driver_register(&driver->driver);
 	if (res)
 	if (res)
-		goto out_unlock;
+		return res;
 	
 	
+	mutex_lock(&core_lists);
+
 	list_add_tail(&driver->list,&drivers);
 	list_add_tail(&driver->list,&drivers);
 	pr_debug("i2c-core: driver [%s] registered\n", driver->driver.name);
 	pr_debug("i2c-core: driver [%s] registered\n", driver->driver.name);
 
 
@@ -311,9 +311,8 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 		}
 		}
 	}
 	}
 
 
- out_unlock:
 	mutex_unlock(&core_lists);
 	mutex_unlock(&core_lists);
-	return res;
+	return 0;
 }
 }
 EXPORT_SYMBOL(i2c_register_driver);
 EXPORT_SYMBOL(i2c_register_driver);