Explorar el Código

ath9k: Fix bug in the way "bf_tx_aborted" of struct ath_buf is used

This bug was introduced by the following commit

	Author: Vasanthakumar Thiagarajan <vasanth@atheros.com>
	Date:   Thu Apr 15 17:38:46 2010 -0400

	ath9k: Remove ATH9K_TX_SW_ABORTED and introduce a bool for this purpose

Wrong buffer is checked for bf_tx_aborted field in ath_tx_num_badfrms(),
this may result in a rate scaling with wrong feedback (number
of unacked frames in this case). It is the last one in the chain
of buffers for an aggregate frame that should be checked.

Also it misses the initialization of this field in the buffer,
this may lead to a situation where we stop the sw retransmission
of failed subframes associated to this buffer.

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Vasanthakumar Thiagarajan hace 15 años
padre
commit
7c9fd60f97
Se han modificado 1 ficheros con 3 adiciones y 1 borrados
  1. 3 1
      drivers/net/wireless/ath/ath9k/xmit.c

+ 3 - 1
drivers/net/wireless/ath/ath9k/xmit.c

@@ -1728,6 +1728,8 @@ static int ath_tx_setup_buffer(struct ieee80211_hw *hw, struct ath_buf *bf,
 	} else
 	} else
 		bf->bf_isnullfunc = false;
 		bf->bf_isnullfunc = false;
 
 
+	bf->bf_tx_aborted = false;
+
 	return 0;
 	return 0;
 }
 }
 
 
@@ -1989,7 +1991,7 @@ static int ath_tx_num_badfrms(struct ath_softc *sc, struct ath_buf *bf,
 	int nbad = 0;
 	int nbad = 0;
 	int isaggr = 0;
 	int isaggr = 0;
 
 
-	if (bf->bf_tx_aborted)
+	if (bf->bf_lastbf->bf_tx_aborted)
 		return 0;
 		return 0;
 
 
 	isaggr = bf_isaggr(bf);
 	isaggr = bf_isaggr(bf);