浏览代码

[POWERPC] spufs: don't requeue victim contex in find_victim if it's not in spu_run

We should not requeue the victim context in find_victim if the owner is
not in spu_run. It's first not needed because leaving the context on
the spu is an optimization and second is harmful because it means the
owner could re-enter spu_run when the context is on the runqueue and
trip the BUG_ON in __spu_update_sched_info.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Christoph Hellwig 17 年之前
父节点
当前提交
7a28a1549f
共有 1 个文件被更改,包括 2 次插入1 次删除
  1. 2 1
      arch/powerpc/platforms/cell/spufs/sched.c

+ 2 - 1
arch/powerpc/platforms/cell/spufs/sched.c

@@ -659,7 +659,8 @@ static struct spu *find_victim(struct spu_context *ctx)
 
 			victim->stats.invol_ctx_switch++;
 			spu->stats.invol_ctx_switch++;
-			spu_add_to_rq(victim);
+			if (test_bit(SPU_SCHED_SPU_RUN, &ctx->sched_flags))
+				spu_add_to_rq(victim);
 
 			mutex_unlock(&victim->state_mutex);