Jelajahi Sumber

[SCSI] scsi_dh_hp_sw: fix deadlock in start_stop_endio

The use of blk_execute_rq_nowait() implies __blk_put_request() is needed
in start_stop_endio() rather than blk_put_request() --
blk_finish_request() is called with queue lock already held.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Mike Snitzer 14 tahun lalu
induk
melakukan
7a1e9d829f
1 mengubah file dengan 2 tambahan dan 1 penghapusan
  1. 2 1
      drivers/scsi/device_handler/scsi_dh_hp_sw.c

+ 2 - 1
drivers/scsi/device_handler/scsi_dh_hp_sw.c

@@ -225,7 +225,8 @@ static void start_stop_endio(struct request *req, int error)
 		}
 	}
 done:
-	blk_put_request(req);
+	req->end_io_data = NULL;
+	__blk_put_request(req->q, req);
 	if (h->callback_fn) {
 		h->callback_fn(h->callback_data, err);
 		h->callback_fn = h->callback_data = NULL;