Browse Source

pinctrl: s3c24xx: off by one in s3c24xx_eint_init()

If "irq == NUM_EINT" then it writes one space beyond the end of the
eint_data->domains[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Dan Carpenter 12 years ago
parent
commit
774e2d981f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/pinctrl/pinctrl-s3c24xx.c

+ 1 - 1
drivers/pinctrl/pinctrl-s3c24xx.c

@@ -549,7 +549,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
 		irq = bank->eint_offset;
 		mask = bank->eint_mask;
 		for (pin = 0; mask; ++pin, mask >>= 1) {
-			if (irq > NUM_EINT)
+			if (irq >= NUM_EINT)
 				break;
 			if (!(mask & 1))
 				continue;