drbd: fix potential activity log refcount imbalance in error path · 76727f684a - Gogs

drbd: fix potential activity log refcount imbalance in error path

It is no longer sufficient to trigger on local WRITE,
we need to check on (rq_state & RQ_IN_ACT_LOG)
before calling drbd_al_complete_io also in the error path.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

Lars Ellenberg 14 years ago

parent

d2e17807e3

commit

76727f684a

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
drivers/block/drbd/drbd_req.c
							 
								View File
							
				@@ -1033,7 +1033,7 @@ fail_conflicting:
			
				 	err = 0;
			
				 fail_free_complete:
			
				-	if (rw == WRITE && local)
			
				+	if (req->rq_state & RQ_IN_ACT_LOG)
			
				 		drbd_al_complete_io(mdev, sector);
			
				 fail_and_free_req:
			
				 	if (local) {