Procházet zdrojové kódy

[PATCH] stop leaking cfq_data in cfq_set_request()

We don't need to pin ->key down; ->cfqq->cfqd will do that for us.
Incidentally, that stops the leak we had - that reference was never
dropped.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Al Viro před 19 roky
rodič
revize
7670876d2d
1 změnil soubory, kde provedl 0 přidání a 2 odebrání
  1. 0 2
      block/cfq-iosched.c

+ 0 - 2
block/cfq-iosched.c

@@ -1433,7 +1433,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)
 		ioc->set_ioprio = cfq_ioc_set_ioprio;
 		cic->ioc = ioc;
 		cic->key = cfqd;
-		atomic_inc(&cfqd->ref);
 	} else {
 		struct cfq_io_context *__cic;
 
@@ -1469,7 +1468,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)
 
 		__cic->ioc = ioc;
 		__cic->key = cfqd;
-		atomic_inc(&cfqd->ref);
 		list_add(&__cic->list, &cic->list);
 		cic = __cic;
 	}