Răsfoiți Sursa

[PATCH] sound/oss/sonicvibes.c: fix an array overflow

This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Adrian Bunk 20 ani în urmă
părinte
comite
76530da1a9
1 a modificat fișierele cu 1 adăugiri și 1 ștergeri
  1. 1 1
      sound/oss/sonicvibes.c

+ 1 - 1
sound/oss/sonicvibes.c

@@ -1149,7 +1149,7 @@ static int mixer_ioctl(struct sv_state *s, unsigned int cmd, unsigned long arg)
 			if (mixtable[i].rec)
 			if (mixtable[i].rec)
 				break;
 				break;
 		}
 		}
-		if (!mixtable[i].rec)
+		if (i == SOUND_MIXER_NRDEVICES)
 			return 0;
 			return 0;
 		spin_lock_irqsave(&s->lock, flags);
 		spin_lock_irqsave(&s->lock, flags);
 		frobindir(s, SV_CIMIX_ADCINL, 0x1f, mixtable[i].rec << 5);
 		frobindir(s, SV_CIMIX_ADCINL, 0x1f, mixtable[i].rec << 5);