Эх сурвалжийг харах

nfsd4; fix session reference count leak

Note the session has to be put() here regardless of what happens to the
client.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
J. Bruce Fields 15 жил өмнө
parent
commit
76407f76e0

+ 0 - 1
fs/nfsd/nfs4state.c

@@ -714,7 +714,6 @@ release_session_client(struct nfsd4_session *session)
 	} else
 	} else
 		renew_client_locked(clp);
 		renew_client_locked(clp);
 	spin_unlock(&client_lock);
 	spin_unlock(&client_lock);
-	nfsd4_put_session(session);
 }
 }
 
 
 /* must be called under the client_lock */
 /* must be called under the client_lock */

+ 1 - 0
fs/nfsd/nfs4xdr.c

@@ -3325,6 +3325,7 @@ nfs4svc_encode_compoundres(struct svc_rqst *rqstp, __be32 *p, struct nfsd4_compo
 		}
 		}
 		/* Renew the clientid on success and on replay */
 		/* Renew the clientid on success and on replay */
 		release_session_client(cs->session);
 		release_session_client(cs->session);
+		nfsd4_put_session(cs->session);
 	}
 	}
 	return 1;
 	return 1;
 }
 }