Home Explore Help
Register Sign In
phyus
/
linux-vybrid_public
8
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

mlx4: fix buffer overrun

When passing MLX4_UC_STEER=1 it was translated to value 2
after mlx4_QP_ATTACH_wrapper. Therefore in new_steering_entry()
unicast steer entries were added to index 2 of array of size 2.
Fixing this bug by shift right to one position.

Signed-off-by: Eugenia Emantayev <eugenia@mellanox.co.il>
Reviewed-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eugenia Emantayev 13 years ago
parent
33b5d30cd8
commit
75c6062cb7
1 changed files with 1 additions and 1 deletions
Split View Show Diff Stats
  1. 1 1
      drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

+ 1 - 1
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
View File 

@@ -2538,7 +2538,7 @@ int mlx4_QP_ATTACH_wrapper(struct mlx4_dev *dev, int slave,
 
 	int attach = vhcr->op_modifier;
 
 	int block_loopback = vhcr->in_modifier >> 31;
 
 	u8 steer_type_mask = 2;
 
-	enum mlx4_steer_type type = gid[7] & steer_type_mask;
 
+	enum mlx4_steer_type type = (gid[7] & steer_type_mask) >> 1;
 
 
 	qpn = vhcr->in_modifier & 0xffffff;
 
 	err = get_res(dev, slave, qpn, RES_QP, &rqp);