Quellcode durchsuchen

[PATCH] i386: fix dump_stack()

i386 has a small bug in the stack dump code where it prints an extra log
level code.  Remove that and fix the alignment of normal stack dump
printout.  Also remove some unnecessary printk() calls.

Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Chuck Ebbert vor 19 Jahren
Ursprung
Commit
75874d5cc8
1 geänderte Dateien mit 4 neuen und 6 gelöschten Zeilen
  1. 4 6
      arch/i386/kernel/traps.c

+ 4 - 6
arch/i386/kernel/traps.c

@@ -217,19 +217,17 @@ static void show_stack_log_lvl(struct task_struct *task, unsigned long *esp,
 	for(i = 0; i < kstack_depth_to_print; i++) {
 	for(i = 0; i < kstack_depth_to_print; i++) {
 		if (kstack_end(stack))
 		if (kstack_end(stack))
 			break;
 			break;
-		if (i && ((i % 8) == 0)) {
-			printk("\n");
-			printk("%s       ", log_lvl);
-		}
+		if (i && ((i % 8) == 0))
+			printk("\n%s       ", log_lvl);
 		printk("%08lx ", *stack++);
 		printk("%08lx ", *stack++);
 	}
 	}
-	printk("\n");
-	printk("%sCall Trace:\n", log_lvl);
+	printk("\n%sCall Trace:\n", log_lvl);
 	show_trace_log_lvl(task, esp, log_lvl);
 	show_trace_log_lvl(task, esp, log_lvl);
 }
 }
 
 
 void show_stack(struct task_struct *task, unsigned long *esp)
 void show_stack(struct task_struct *task, unsigned long *esp)
 {
 {
+	printk("       ");
 	show_stack_log_lvl(task, esp, "");
 	show_stack_log_lvl(task, esp, "");
 }
 }