瀏覽代碼

ore: signedness bug in _sp2d_min_pg()

This for loop doesn't work correctly when "p" is unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan Carpenter 12 年之前
父節點
當前提交
74b217d0d3
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/exofs/ore_raid.c

+ 1 - 1
fs/exofs/ore_raid.c

@@ -203,7 +203,7 @@ static unsigned _sp2d_min_pg(struct __stripe_pages_2d *sp2d)
 
 
 static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d)
 static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d)
 {
 {
-	unsigned p;
+	int p;
 
 
 	for (p = sp2d->pages_in_unit - 1; p >= 0; --p) {
 	for (p = sp2d->pages_in_unit - 1; p >= 0; --p) {
 		struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p];
 		struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p];