Browse Source

cdc_ether: Partially revert "usbnet: Set link down initially ..."

Commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71 ("usbnet: Set link down
initially for drivers that update link state") changed the initial link
state in cdc_ether and other drivers based on the understanding that the
devices they support generate link change interrupts.  However, this is
optional in the CDC Ethernet protocol, and two users have reported in
<http://bugzilla.kernel.org/show_bug.cgi?id=14791> that the link state
for their devices remains down.  Therefore, revert the change in
cdc_ether.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Tested-by: Avi Rozen <avi.rozen@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ben Hutchings 15 years ago
parent
commit
71cc1fa9f2
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/usb/cdc_ether.c

+ 1 - 1
drivers/net/usb/cdc_ether.c

@@ -419,7 +419,7 @@ static int cdc_manage_power(struct usbnet *dev, int on)
 
 
 static const struct driver_info	cdc_info = {
 static const struct driver_info	cdc_info = {
 	.description =	"CDC Ethernet Device",
 	.description =	"CDC Ethernet Device",
-	.flags =	FLAG_ETHER | FLAG_LINK_INTR,
+	.flags =	FLAG_ETHER,
 	// .check_connect = cdc_check_connect,
 	// .check_connect = cdc_check_connect,
 	.bind =		cdc_bind,
 	.bind =		cdc_bind,
 	.unbind =	usbnet_cdc_unbind,
 	.unbind =	usbnet_cdc_unbind,