Browse Source

IB/ipath: Fix sparse warning about pointer signedness

There's no reason for the third parameter of ipath_count_units() to be
a u32 *, so change it to be an int * instead.  This fixes the sparse
warning:

    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47: warning: incorrect type in argument 3 (different signedness)
    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47:    expected unsigned int [usertype] *maxportsp
    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47:    got int *<noident>

Signed-off-by: Arthur Jones <arthur.jones@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Arthur Jones 17 years ago
parent
commit
6ef6aee2f0

+ 2 - 2
drivers/infiniband/hw/ipath/ipath_driver.c

@@ -234,12 +234,12 @@ struct ipath_devdata *ipath_lookup(int unit)
 	return dd;
 	return dd;
 }
 }
 
 
-int ipath_count_units(int *npresentp, int *nupp, u32 *maxportsp)
+int ipath_count_units(int *npresentp, int *nupp, int *maxportsp)
 {
 {
 	int nunits, npresent, nup;
 	int nunits, npresent, nup;
 	struct ipath_devdata *dd;
 	struct ipath_devdata *dd;
 	unsigned long flags;
 	unsigned long flags;
-	u32 maxports;
+	int maxports;
 
 
 	nunits = npresent = nup = maxports = 0;
 	nunits = npresent = nup = maxports = 0;
 
 

+ 1 - 1
drivers/infiniband/hw/ipath/ipath_kernel.h

@@ -718,7 +718,7 @@ extern struct ipath_devdata *ipath_lookup(int unit);
 int ipath_init_chip(struct ipath_devdata *, int);
 int ipath_init_chip(struct ipath_devdata *, int);
 int ipath_enable_wc(struct ipath_devdata *dd);
 int ipath_enable_wc(struct ipath_devdata *dd);
 void ipath_disable_wc(struct ipath_devdata *dd);
 void ipath_disable_wc(struct ipath_devdata *dd);
-int ipath_count_units(int *npresentp, int *nupp, u32 *maxportsp);
+int ipath_count_units(int *npresentp, int *nupp, int *maxportsp);
 void ipath_shutdown_device(struct ipath_devdata *);
 void ipath_shutdown_device(struct ipath_devdata *);
 void ipath_clear_freeze(struct ipath_devdata *);
 void ipath_clear_freeze(struct ipath_devdata *);