Jelajahi Sumber

mempolicy: remove case MPOL_INTERLEAVE from policy_zonelist()

In policy_zonelist() mode MPOL_INTERLEAVE shouldn't happen, so fall
through to BUG() instead of break to return.  I also fixed the comment.

Signed-off-by: Bob Liu <lliubbo@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Bob Liu 15 tahun lalu
induk
melakukan
6eb27e1fdf
1 mengubah file dengan 1 tambahan dan 3 penghapusan
  1. 1 3
      mm/mempolicy.c

+ 1 - 3
mm/mempolicy.c

@@ -1441,15 +1441,13 @@ static struct zonelist *policy_zonelist(gfp_t gfp, struct mempolicy *policy)
 		/*
 		/*
 		 * Normally, MPOL_BIND allocations are node-local within the
 		 * Normally, MPOL_BIND allocations are node-local within the
 		 * allowed nodemask.  However, if __GFP_THISNODE is set and the
 		 * allowed nodemask.  However, if __GFP_THISNODE is set and the
-		 * current node is part of the mask, we use the zonelist for
+		 * current node isn't part of the mask, we use the zonelist for
 		 * the first node in the mask instead.
 		 * the first node in the mask instead.
 		 */
 		 */
 		if (unlikely(gfp & __GFP_THISNODE) &&
 		if (unlikely(gfp & __GFP_THISNODE) &&
 				unlikely(!node_isset(nd, policy->v.nodes)))
 				unlikely(!node_isset(nd, policy->v.nodes)))
 			nd = first_node(policy->v.nodes);
 			nd = first_node(policy->v.nodes);
 		break;
 		break;
-	case MPOL_INTERLEAVE: /* should not happen */
-		break;
 	default:
 	default:
 		BUG();
 		BUG();
 	}
 	}