Ver Fonte

virtio_net: remove overzealous printk

The 'disable_cb' is really just a hint and as such, it's possible for more
work to get queued up while callbacks are disabled.  Under stress with an
SMP guest, this printk triggers very frequently.  There is no race here, this
is how things are designed to work so let's just remove the printk.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Anthony Liguori há 17 anos atrás
pai
commit
6ea0a4679d
1 ficheiros alterados com 0 adições e 1 exclusões
  1. 0 1
      drivers/net/virtio_net.c

+ 0 - 1
drivers/net/virtio_net.c

@@ -284,7 +284,6 @@ again:
 		/* Activate callback for using skbs: if this returns false it
 		/* Activate callback for using skbs: if this returns false it
 		 * means some were used in the meantime. */
 		 * means some were used in the meantime. */
 		if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) {
 		if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) {
-			printk("Unlikely: restart svq race\n");
 			vi->svq->vq_ops->disable_cb(vi->svq);
 			vi->svq->vq_ops->disable_cb(vi->svq);
 			netif_start_queue(dev);
 			netif_start_queue(dev);
 			goto again;
 			goto again;