Browse Source

KVM: MMU: fix mmu notifier invalidate handler for huge spte

The index wasn't calculated correctly (off by one) for huge spte so KVM guest
was unstable with transparent hugepages.

Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Reviewed-by: Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Andrea Arcangeli 15 năm trước cách đây
mục cha
commit
6e3e243c3b
1 tập tin đã thay đổi với 6 bổ sung2 xóa
  1. 6 2
      arch/x86/kvm/mmu.c

+ 6 - 2
arch/x86/kvm/mmu.c

@@ -850,8 +850,12 @@ static int kvm_handle_hva(struct kvm *kvm, unsigned long hva,
 			ret = handler(kvm, &memslot->rmap[gfn_offset], data);
 			ret = handler(kvm, &memslot->rmap[gfn_offset], data);
 
 
 			for (j = 0; j < KVM_NR_PAGE_SIZES - 1; ++j) {
 			for (j = 0; j < KVM_NR_PAGE_SIZES - 1; ++j) {
-				int idx = gfn_offset;
-				idx /= KVM_PAGES_PER_HPAGE(PT_DIRECTORY_LEVEL + j);
+				unsigned long idx;
+				int sh;
+
+				sh = KVM_HPAGE_GFN_SHIFT(PT_DIRECTORY_LEVEL+j);
+				idx = ((memslot->base_gfn+gfn_offset) >> sh) -
+					(memslot->base_gfn >> sh);
 				ret |= handler(kvm,
 				ret |= handler(kvm,
 					&memslot->lpage_info[j][idx].rmap_pde,
 					&memslot->lpage_info[j][idx].rmap_pde,
 					data);
 					data);