Selaa lähdekoodia

arch/mn10300/mm: eliminate NULL dereference

dev_name always dereferences its argument, so it should not be called if
the argument is NULL.  The function indeed later tests the argument for
being NULL.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

  // <smpl>
  @@
  expression dev,E;
  @@

  *dev_name(dev)
  ... when != dev = E
  (
  *dev == NULL
  |
  *dev != NULL
  )
  // </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Julia Lawall 14 vuotta sitten
vanhempi
commit
6e0c64f4dd
1 muutettua tiedostoa jossa 2 lisäystä ja 1 poistoa
  1. 2 1
      arch/mn10300/mm/dma-alloc.c

+ 2 - 1
arch/mn10300/mm/dma-alloc.c

@@ -25,7 +25,8 @@ void *dma_alloc_coherent(struct device *dev, size_t size,
 	unsigned long addr;
 	unsigned long addr;
 	void *ret;
 	void *ret;
 
 
-	printk("dma_alloc_coherent(%s,%zu,,%x)\n", dev_name(dev), size, gfp);
+	pr_debug("dma_alloc_coherent(%s,%zu,%x)\n",
+		 dev ? dev_name(dev) : "?", size, gfp);
 
 
 	if (0xbe000000 - pci_sram_allocated >= size) {
 	if (0xbe000000 - pci_sram_allocated >= size) {
 		size = (size + 255) & ~255;
 		size = (size + 255) & ~255;