浏览代码

xfs: fix remount rw with unrecognized options

When we skip unrecognized options in xfs_fs_remount we should just break
out of the switch and not return because otherwise we may skip clearing
the xfs-internal read-only flag.  This will only show up on some
operations like touch because most read-only checks are done by the VFS
which thinks this filesystem is r/w.  Eventually we should replace the
XFS read-only flag with a helper that always checks the VFS flag to make
sure they can never get out of sync.

Bug reported and fix verified by Marcel Beister on #xfs.
Bug fix verified by updated xfstests/189.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Timothy Shimmin <tes@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Christoph Hellwig 16 年之前
父节点
当前提交
6c5e51dae2
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/xfs/linux-2.6/xfs_super.c

+ 1 - 1
fs/xfs/linux-2.6/xfs_super.c

@@ -1323,7 +1323,7 @@ xfs_fs_remount(
 	"XFS: mount option \"%s\" not supported for remount\n", p);
 	"XFS: mount option \"%s\" not supported for remount\n", p);
 			return -EINVAL;
 			return -EINVAL;
 #else
 #else
-			return 0;
+			break;
 #endif
 #endif
 		}
 		}
 	}
 	}