瀏覽代碼

x86: vdso: Remove bogus locking in update_vsyscall_tz()

Changing the sequence count in update_vsyscall_tz() is completely
pointless.

The vdso code copies the data unprotected. There is no point to change
this as sys_tz is nowhere protected at all. See sys_gettimeofday().

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Thomas Gleixner 13 年之前
父節點
當前提交
6c260d5863
共有 1 個文件被更改,包括 0 次插入5 次删除
  1. 0 5
      arch/x86/kernel/vsyscall_64.c

+ 0 - 5
arch/x86/kernel/vsyscall_64.c

@@ -80,12 +80,7 @@ early_param("vsyscall", vsyscall_setup);
 
 
 void update_vsyscall_tz(void)
 void update_vsyscall_tz(void)
 {
 {
-	unsigned long flags;
-
-	write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags);
-	/* sys_tz has changed */
 	vsyscall_gtod_data.sys_tz = sys_tz;
 	vsyscall_gtod_data.sys_tz = sys_tz;
-	write_sequnlock_irqrestore(&vsyscall_gtod_data.lock, flags);
 }
 }
 
 
 void update_vsyscall(struct timespec *wall_time, struct timespec *wtm,
 void update_vsyscall(struct timespec *wall_time, struct timespec *wtm,